From fe38af05a84abc15243bacf55a63f6f9aae37a33 Mon Sep 17 00:00:00 2001 From: Michael Muré Date: Sat, 29 Feb 2020 15:04:48 +0100 Subject: github: correct casing for user provided login --- commands/bridge_auth_addtoken.go | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'commands') diff --git a/commands/bridge_auth_addtoken.go b/commands/bridge_auth_addtoken.go index 338b170e..8eda28ac 100644 --- a/commands/bridge_auth_addtoken.go +++ b/commands/bridge_auth_addtoken.go @@ -24,6 +24,12 @@ var ( ) func runBridgeTokenAdd(cmd *cobra.Command, args []string) error { + // Note: as bridgeAuthAddTokenLogin is not checked against the remote bug-tracker, + // it's possible to register a credential with an incorrect login (including bad case). + // The consequence is that it will not get picked later by the bridge. I find that + // checking it would require a cumbersome UX (need to provide a base URL for some bridges, ...) + // so it's probably not worth it, unless we refactor that entirely. + if bridgeAuthAddTokenTarget == "" { return fmt.Errorf("flag --target is required") } -- cgit