From 3d454d9dc8ba2409046c0938618a70864e6eb8ef Mon Sep 17 00:00:00 2001 From: Michael Muré Date: Mon, 25 Jul 2022 13:16:16 +0200 Subject: entity/dag: proper base operation for simplified implementation - reduce boilerplace necessary to implement an operation - consolidate what an operation is in the core, which in turn pave the way for a generic cache layer mechanism - avoid the previously complex unmarshalling process - support operation metadata from the core - simplified testing --- bug/interface.go | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) (limited to 'bug/interface.go') diff --git a/bug/interface.go b/bug/interface.go index e71496a9..27a84dc5 100644 --- a/bug/interface.go +++ b/bug/interface.go @@ -19,17 +19,17 @@ type Interface interface { // Operations return the ordered operations Operations() []Operation - // Indicate that the in-memory state changed and need to be commit in the repository + // NeedCommit indicate that the in-memory state changed and need to be commit in the repository NeedCommit() bool // Commit write the staging area in Git and move the operations to the packs Commit(repo repository.ClockedRepo) error - // Lookup for the very first operation of the bug. + // FirstOp lookup for the very first operation of the bug. // For a valid Bug, this operation should be a CreateOp FirstOp() Operation - // Lookup for the very last operation of the bug. + // LastOp lookup for the very last operation of the bug. // For a valid Bug, should never be nil LastOp() Operation @@ -42,14 +42,3 @@ type Interface interface { // EditLamportTime return the Lamport time of the last edit EditLamportTime() lamport.Time } - -func bugFromInterface(bug Interface) *Bug { - switch bug := bug.(type) { - case *Bug: - return bug - case *WithSnapshot: - return bug.Bug - default: - panic("missing type case") - } -} -- cgit