From 88ad7e606f1cbf9e47b968a208e3510f7f9a81c5 Mon Sep 17 00:00:00 2001 From: Michael Muré Date: Tue, 23 Jun 2020 18:02:54 +0200 Subject: repository: remove tie to Bug, improved and reusable testing - allow the creation of arbitrary Lamport clocks, freeing the way to new entities and removing Bug specific (upper layer) code. - generalize the memory-only and persisted Lamport clocks behind a common interface - rework the tests to provide reusable testing code for a Repo, a Clock, a Config, opening a path to add a new Repo implementation more easily - test previously untested components with those new tests Note: one problem found during this endeavor is that `identity.Version` also need to store one time + Lamport time for each other Entity (Bug, config, PR ...). This could possibly done without breaking change but it would be much easier to wait for https://github.com/MichaelMure/git-bug-migration to happen. --- bridge/gitlab/export_test.go | 4 ++-- bridge/gitlab/import_test.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'bridge/gitlab') diff --git a/bridge/gitlab/export_test.go b/bridge/gitlab/export_test.go index d8966163..6c151d61 100644 --- a/bridge/gitlab/export_test.go +++ b/bridge/gitlab/export_test.go @@ -143,7 +143,7 @@ func TestPushPull(t *testing.T) { // create repo backend repo := repository.CreateTestRepo(false) - defer repository.CleanupTestRepos(t, repo) + defer repository.CleanupTestRepos(repo) backend, err := cache.NewRepoCache(repo) require.NoError(t, err) @@ -216,7 +216,7 @@ func TestPushPull(t *testing.T) { fmt.Printf("test repository exported in %f seconds\n", time.Since(start).Seconds()) repoTwo := repository.CreateTestRepo(false) - defer repository.CleanupTestRepos(t, repoTwo) + defer repository.CleanupTestRepos(repoTwo) // create a second backend backendTwo, err := cache.NewRepoCache(repoTwo) diff --git a/bridge/gitlab/import_test.go b/bridge/gitlab/import_test.go index 42a37cda..9a936ae4 100644 --- a/bridge/gitlab/import_test.go +++ b/bridge/gitlab/import_test.go @@ -77,7 +77,7 @@ func TestImport(t *testing.T) { } repo := repository.CreateTestRepo(false) - defer repository.CleanupTestRepos(t, repo) + defer repository.CleanupTestRepos(repo) backend, err := cache.NewRepoCache(repo) require.NoError(t, err) -- cgit