From 13f98d0cc47cde61aeff62f1656ec6b4b5922c1c Mon Sep 17 00:00:00 2001 From: amine Date: Tue, 5 Nov 2019 21:03:16 +0100 Subject: bridge/github: improve iterator NextTimelineItem function --- bridge/github/iterator.go | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'bridge/github') diff --git a/bridge/github/iterator.go b/bridge/github/iterator.go index a97ed036..786f0fbf 100644 --- a/bridge/github/iterator.go +++ b/bridge/github/iterator.go @@ -214,6 +214,7 @@ func (i *iterator) NextTimelineItem() bool { return false } + // after NextIssue call it's good to check wether we have some timeline items or not if len(i.timeline.query.Repository.Issues.Nodes[0].Timeline.Edges) == 0 { return false } @@ -240,6 +241,11 @@ func (i *iterator) NextTimelineItem() bool { return false } + // (in case github returns something wierd) just for safety: better return a false than a panic + if len(i.timeline.query.Repository.Issues.Nodes[0].Timeline.Edges) == 0 { + return false + } + i.reverseTimelineEditNodes() i.timeline.index = 0 return true -- cgit