From 1f365b236900d429cbfdaa1807163a110e6e4624 Mon Sep 17 00:00:00 2001 From: Amine Hilaly Date: Tue, 25 Jun 2019 01:33:48 +0200 Subject: [core] Implement ExportResults Use ExportResult chan to send export events Remove exportedBugs and exportedLabels --- bridge/core/bridge.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'bridge/core/bridge.go') diff --git a/bridge/core/bridge.go b/bridge/core/bridge.go index 1b960e0e..30e051be 100644 --- a/bridge/core/bridge.go +++ b/bridge/core/bridge.go @@ -297,21 +297,21 @@ func (b *Bridge) ImportAll(since time.Time) error { return importer.ImportAll(b.repo, since) } -func (b *Bridge) ExportAll(since time.Time) error { +func (b *Bridge) ExportAll(since time.Time) (<-chan ExportResult, error) { exporter := b.getExporter() if exporter == nil { - return ErrExportNotSupported + return nil, ErrExportNotSupported } err := b.ensureConfig() if err != nil { - return err + return nil, err } err = b.ensureInit() if err != nil { - return err + return nil, err } - return exporter.ExportAll(b.repo, since) + return exporter.ExportAll(b.repo, since), nil } -- cgit From 93e731fd0d365c0cf49dbb7aea371e48f46e1f11 Mon Sep 17 00:00:00 2001 From: Amine Date: Fri, 5 Jul 2019 18:32:51 +0200 Subject: [bridge/github] improve comments and documentation MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [bridge/github] improve error handling and tests Co-Authored-By: Michael Muré --- bridge/core/bridge.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'bridge/core/bridge.go') diff --git a/bridge/core/bridge.go b/bridge/core/bridge.go index 30e051be..d04e88e4 100644 --- a/bridge/core/bridge.go +++ b/bridge/core/bridge.go @@ -313,5 +313,5 @@ func (b *Bridge) ExportAll(since time.Time) (<-chan ExportResult, error) { return nil, err } - return exporter.ExportAll(b.repo, since), nil + return exporter.ExportAll(b.repo, since) } -- cgit