From fe231231c68e1f117b6018e008d6d09812604043 Mon Sep 17 00:00:00 2001 From: Michael Muré Date: Sun, 5 Jun 2022 13:23:02 +0200 Subject: graphql: fix two invalid mutex lock leading to data races --- api/graphql/models/lazy_identity.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'api/graphql/models/lazy_identity.go') diff --git a/api/graphql/models/lazy_identity.go b/api/graphql/models/lazy_identity.go index 002c38e4..451bdd54 100644 --- a/api/graphql/models/lazy_identity.go +++ b/api/graphql/models/lazy_identity.go @@ -41,13 +41,13 @@ func NewLazyIdentity(cache *cache.RepoCache, excerpt *cache.IdentityExcerpt) *la } func (li *lazyIdentity) load() (*cache.IdentityCache, error) { + li.mu.Lock() + defer li.mu.Unlock() + if li.id != nil { return li.id, nil } - li.mu.Lock() - defer li.mu.Unlock() - id, err := li.cache.ResolveIdentity(li.excerpt.Id) if err != nil { return nil, fmt.Errorf("cache: missing identity %v", li.excerpt.Id) -- cgit