From f093be96e98284580d61664adecd0a2ff8b354e4 Mon Sep 17 00:00:00 2001 From: Michael Muré Date: Mon, 3 Feb 2020 22:02:01 +0100 Subject: cache: don't store legacy identities IDs in bug excerpt as they are not reachable. Fix a panic --- cache/bug_excerpt.go | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/cache/bug_excerpt.go b/cache/bug_excerpt.go index e053f9e4..36c7dcfe 100644 --- a/cache/bug_excerpt.go +++ b/cache/bug_excerpt.go @@ -61,14 +61,18 @@ func (l LegacyAuthorExcerpt) DisplayName() string { } func NewBugExcerpt(b bug.Interface, snap *bug.Snapshot) *BugExcerpt { - participantsIds := make([]entity.Id, len(snap.Participants)) - for i, participant := range snap.Participants { - participantsIds[i] = participant.Id() + participantsIds := make([]entity.Id, 0, len(snap.Participants)) + for _, participant := range snap.Participants { + if _, ok := participant.(*identity.Identity); ok { + participantsIds = append(participantsIds, participant.Id()) + } } - actorsIds := make([]entity.Id, len(snap.Actors)) - for i, actor := range snap.Actors { - actorsIds[i] = actor.Id() + actorsIds := make([]entity.Id, 0, len(snap.Actors)) + for _, actor := range snap.Actors { + if _, ok := actor.(*identity.Identity); ok { + actorsIds = append(actorsIds, actor.Id()) + } } e := &BugExcerpt{ -- cgit