From 160ba2420b0d09b744d96c102f863134a6f8cfd8 Mon Sep 17 00:00:00 2001 From: Alexander Scharinger Date: Sat, 4 Dec 2021 09:43:46 +0100 Subject: Fix: github import, some issue titles cause error --- bridge/github/import.go | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/bridge/github/import.go b/bridge/github/import.go index a41083d2..5d18bd19 100644 --- a/bridge/github/import.go +++ b/bridge/github/import.go @@ -195,12 +195,11 @@ func (gi *githubImporter) ensureIssue(ctx context.Context, repo *cache.RepoCache } // At Github there exist issues with seemingly empty titles. An example is - // https://github.com/NixOS/nixpkgs/issues/72730 . - // The title provided by the GraphQL API actually consists of a space followed by a - // zero width space (U+200B). This title would cause the NewBugRaw() function to - // return an error: empty title. - title := string(issue.Title) - if title == " \u200b" { // U+200B == zero width space + // https://github.com/NixOS/nixpkgs/issues/72730 (here the title is actually + // a zero width space U+200B). + // Set title to some non-empty string, since git-bug does not accept empty titles. + title := text.CleanupOneLine(string(issue.Title)) + if text.Empty(title) { title = EmptyTitlePlaceholder } @@ -375,12 +374,11 @@ func (gi *githubImporter) ensureTimelineItem(ctx context.Context, repo *cache.Re } // At Github there exist issues with seemingly empty titles. An example is - // https://github.com/NixOS/nixpkgs/issues/72730 . - // The title provided by the GraphQL API actually consists of a space followed - // by a zero width space (U+200B). This title would cause the NewBugRaw() - // function to return an error: empty title. + // https://github.com/NixOS/nixpkgs/issues/72730 (here the title is actually + // a zero width space U+200B). + // Set title to some non-empty string, since git-bug does not accept empty titles. title := text.CleanupOneLine(string(item.RenamedTitleEvent.CurrentTitle)) - if title == " \u200b" { // U+200B == zero width space + if text.Empty(title) { title = EmptyTitlePlaceholder } -- cgit