repository: remove tie to Bug, improved and reusable testing

- allow the creation of arbitrary Lamport clocks, freeing the way to new entities and removing Bug specific (upper layer) code.
- generalize the memory-only and persisted Lamport clocks behind a common interface
- rework the tests to provide reusable testing code for a Repo, a Clock, a Config, opening a path to add a new Repo implementation more easily
- test previously untested components with those new tests

Note: one problem found during this endeavor is that `identity.Version` also need to store one time + Lamport time for each other Entity (Bug, config, PR ...). This could possibly done without breaking change but it would be much easier to wait for https://github.com/MichaelMure/git-bug-migration to happen.

1 files changed, 63 insertions, 0 deletions

diff --git a/repository/config_testing.go b/repository/config_testing.go
new file mode 100644
index 00000000..25639d59
--- /dev/null
+++ b/repository/config_testing.go
@@ -0,0 +1,63 @@
+package repository
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func testConfig(t *testing.T, config Config) {
+	err := config.StoreString("section.key", "value")
+	assert.NoError(t, err)
+
+	val, err := config.ReadString("section.key")
+	assert.NoError(t, err)
+	assert.Equal(t, "value", val)
+
+	err = config.StoreString("section.true", "true")
+	assert.NoError(t, err)
+
+	val2, err := config.ReadBool("section.true")
+	assert.NoError(t, err)
+	assert.Equal(t, true, val2)
+
+	configs, err := config.ReadAll("section")
+	assert.NoError(t, err)
+	assert.Equal(t, map[string]string{
+		"section.key":  "value",
+		"section.true": "true",
+	}, configs)
+
+	err = config.RemoveAll("section.true")
+	assert.NoError(t, err)
+
+	configs, err = config.ReadAll("section")
+	assert.NoError(t, err)
+	assert.Equal(t, map[string]string{
+		"section.key": "value",
+	}, configs)
+
+	_, err = config.ReadBool("section.true")
+	assert.Equal(t, ErrNoConfigEntry, err)
+
+	err = config.RemoveAll("section.nonexistingkey")
+	assert.Error(t, err)
+
+	err = config.RemoveAll("section.key")
+	assert.NoError(t, err)
+
+	_, err = config.ReadString("section.key")
+	assert.Equal(t, ErrNoConfigEntry, err)
+
+	err = config.RemoveAll("nonexistingsection")
+	assert.Error(t, err)
+
+	err = config.RemoveAll("section")
+	assert.Error(t, err)
+
+	_, err = config.ReadString("section.key")
+	assert.Error(t, err)
+
+	err = config.RemoveAll("section.key")
+	assert.Error(t, err)
+}