diff options
| author | Michael Muré <batolettre@gmail.com> | 2020-06-23 18:02:54 +0200 |
|---|---|---|
| committer | Michael Muré <batolettre@gmail.com> | 2020-06-26 19:14:22 +0200 |
| commit | 88ad7e606f1cbf9e47b968a208e3510f7f9a81c5 (patch) | |
| tree | 00e847500b34c6f9a721c71474993d1c08ae8fb1 /identity/version.go | |
| parent | 2dd0dbb1344ae9293aae05346f977b5d5907934b (diff) | |
| download | git-bug-88ad7e606f1cbf9e47b968a208e3510f7f9a81c5.tar.gz | |
repository: remove tie to Bug, improved and reusable testing
- allow the creation of arbitrary Lamport clocks, freeing the way to new entities and removing Bug specific (upper layer) code.
- generalize the memory-only and persisted Lamport clocks behind a common interface
- rework the tests to provide reusable testing code for a Repo, a Clock, a Config, opening a path to add a new Repo implementation more easily
- test previously untested components with those new tests
Note: one problem found during this endeavor is that `identity.Version` also need to store one time + Lamport time for each other Entity (Bug, config, PR ...). This could possibly done without breaking change but it would be much easier to wait for https://github.com/MichaelMure/git-bug-migration to happen.
Diffstat (limited to 'identity/version.go')
| -rw-r--r-- | identity/version.go | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/identity/version.go b/identity/version.go index 757b029f..2359bd11 100644 --- a/identity/version.go +++ b/identity/version.go @@ -20,6 +20,9 @@ type Version struct { // The lamport time at which this version become effective // The reference time is the bug edition lamport clock // It must be the first field in this struct due to https://github.com/golang/go/issues/599 + // + // TODO: BREAKING CHANGE - this need to actually be one edition lamport time **per entity** + // This is not a problem right now but will be when more entities are added (pull-request, config ...) time lamport.Time unixTime int64 |