Merge pull request #343 from MichaelMure/login-is-back

identity: bring back the login to hold that info from bridges

1 files changed, 12 insertions, 0 deletions

diff --git a/identity/interface.go b/identity/interface.go
index d138362d..bbb94be7 100644
--- a/identity/interface.go
+++ b/identity/interface.go
@@ -12,18 +12,30 @@ type Interface interface {
 	Id() entity.Id
 
 	// Name return the last version of the name
+	// Can be empty.
 	Name() string
 
 	// Email return the last version of the email
+	// Can be empty.
 	Email() string
 
+	// Login return the last version of the login
+	// Can be empty.
+	// Warning: this login can be defined when importing from a bridge but should *not* be
+	// used to identify an identity as multiple bridge with different login can map to the same
+	// identity. Use the metadata system for that usage instead.
+	Login() string
+
 	// AvatarUrl return the last version of the Avatar URL
+	// Can be empty.
 	AvatarUrl() string
 
 	// Keys return the last version of the valid keys
+	// Can be empty.
 	Keys() []*Key
 
 	// ValidKeysAtTime return the set of keys valid at a given lamport time
+	// Can be empty.
 	ValidKeysAtTime(time lamport.Time) []*Key
 
 	// DisplayName return a non-empty string to display, representing the