diff options
author | Steve Moyer <smoyer1@selesy.com> | 2022-09-25 17:54:56 -0400 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-09-25 17:54:56 -0400 |
commit | d92c1159f84e07bc6ddb68ba1e5159b44caceb29 (patch) | |
tree | 15c9b2d7db8324cc96b3cc7273c039c50d8155c9 /commands | |
parent | 8364cb221b2d0d0cfaf9baa3322abdc93cd2258a (diff) | |
parent | 0ffa79ef13890d4bd46079205b3f6682b93985e9 (diff) | |
download | git-bug-d92c1159f84e07bc6ddb68ba1e5159b44caceb29.tar.gz |
Merge pull request #885 from MichaelMure/feat-530-make-label-commands-consistent
feat(530): make label commands consistent
Diffstat (limited to 'commands')
-rw-r--r-- | commands/label.go | 3 | ||||
-rw-r--r-- | commands/label_ls.go | 33 | ||||
-rw-r--r-- | commands/ls-labels.go | 18 |
3 files changed, 42 insertions, 12 deletions
diff --git a/commands/label.go b/commands/label.go index 906974a5..ff4d0151 100644 --- a/commands/label.go +++ b/commands/label.go @@ -20,13 +20,14 @@ func newLabelCommand() *cobra.Command { } cmd.AddCommand(newLabelAddCommand()) + cmd.AddCommand(newLabelLsCommand()) cmd.AddCommand(newLabelRmCommand()) return cmd } func runLabel(env *Env, args []string) error { - b, args, err := _select.ResolveBug(env.backend, args) + b, _, err := _select.ResolveBug(env.backend, args) if err != nil { return err } diff --git a/commands/label_ls.go b/commands/label_ls.go new file mode 100644 index 00000000..242eb00c --- /dev/null +++ b/commands/label_ls.go @@ -0,0 +1,33 @@ +package commands + +import ( + "github.com/spf13/cobra" +) + +func newLabelLsCommand() *cobra.Command { + env := newEnv() + + cmd := &cobra.Command{ + Use: "ls", + Short: "List valid labels.", + Long: `List valid labels. + +Note: in the future, a proper label policy could be implemented where valid labels are defined in a configuration file. Until that, the default behavior is to return the list of labels already used.`, + PreRunE: loadBackend(env), + RunE: closeBackend(env, func(cmd *cobra.Command, args []string) error { + return runLabelLs(env) + }), + } + + return cmd +} + +func runLabelLs(env *Env) error { + labels := env.backend.ValidLabels() + + for _, l := range labels { + env.out.Println(l) + } + + return nil +} diff --git a/commands/ls-labels.go b/commands/ls-labels.go index 086943a9..00fc3fe6 100644 --- a/commands/ls-labels.go +++ b/commands/ls-labels.go @@ -15,19 +15,15 @@ func newLsLabelCommand() *cobra.Command { Note: in the future, a proper label policy could be implemented where valid labels are defined in a configuration file. Until that, the default behavior is to return the list of labels already used.`, PreRunE: loadBackend(env), RunE: closeBackend(env, func(cmd *cobra.Command, args []string) error { - return runLsLabel(env) + return runLabelLs(env) }), - } - - return cmd -} - -func runLsLabel(env *Env) error { - labels := env.backend.ValidLabels() + Deprecated: ` and will be removed in v1.0. - for _, l := range labels { - env.out.Println(l) +The functionality provided by this command is now provided by +the following (equivalent) command: +git-bug label ls +`, } - return nil + return cmd } |