cache: provide a generic bug sorting function

2 files changed, 85 insertions, 55 deletions

diff --git a/cache/repo_cache.go b/cache/repo_cache.go
index 8f43ad71..d5dd4c59 100644
--- a/cache/repo_cache.go
+++ b/cache/repo_cache.go
@@ -8,7 +8,6 @@ import (
 	"io/ioutil"
 	"os"
 	"path"
-	"sort"
 	"strconv"
 	"strings"
 
@@ -154,6 +153,18 @@ func (c *RepoCache) buildAllExcerpt() {
 	}
 }
 
+func (c *RepoCache) allExcerpt() []BugExcerpt {
+	result := make([]BugExcerpt, len(c.excerpts))
+
+	i := 0
+	for _, val := range c.excerpts {
+		result[i] = val
+		i++
+	}
+
+	return result
+}
+
 func (c *RepoCache) ResolveBug(id string) (*BugCache, error) {
 	cached, ok := c.bugs[id]
 	if ok {
@@ -204,60 +215,6 @@ func (c *RepoCache) ResolveBugPrefix(prefix string) (*BugCache, error) {
 	return cached, nil
 }
 
-func (c *RepoCache) AllBugOrderById() []string {
-	result := make([]string, len(c.excerpts))
-
-	i := 0
-	for key := range c.excerpts {
-		result[i] = key
-		i++
-	}
-
-	sort.Strings(result)
-
-	return result
-}
-
-func (c *RepoCache) AllBugsOrderByEdit() []string {
-	excerpts := make([]BugExcerpt, len(c.excerpts))
-
-	i := 0
-	for _, val := range c.excerpts {
-		excerpts[i] = val
-		i++
-	}
-
-	sort.Sort(BugsByEditTime(excerpts))
-
-	result := make([]string, len(excerpts))
-
-	for i, val := range excerpts {
-		result[i] = val.Id
-	}
-
-	return result
-}
-
-func (c *RepoCache) AllBugsOrderByCreation() []string {
-	excerpts := make([]BugExcerpt, len(c.excerpts))
-
-	i := 0
-	for _, val := range c.excerpts {
-		excerpts[i] = val
-		i++
-	}
-
-	sort.Sort(BugsByCreationTime(excerpts))
-
-	result := make([]string, len(excerpts))
-
-	for i, val := range excerpts {
-		result[i] = val.Id
-	}
-
-	return result
-}
-
 // ClearAllBugs clear all bugs kept in memory
 func (c *RepoCache) ClearAllBugs() {
 	c.bugs = make(map[string]*BugCache)
diff --git a/cache/sorting.go b/cache/sorting.go
new file mode 100644
index 00000000..eeeb315c
--- /dev/null
+++ b/cache/sorting.go
@@ -0,0 +1,73 @@
+package cache
+
+import "sort"
+
+type OrderBy int
+
+const (
+	_ OrderBy = iota
+	OrderById
+	OrderByCreation
+	OrderByEdit
+)
+
+type OrderDirection int
+
+const (
+	_ OrderDirection = iota
+	OrderAscending
+	OrderDescending
+)
+
+func (c *RepoCache) AllBugsId(order OrderBy, direction OrderDirection) []string {
+	if order == OrderById {
+		return c.orderIds(direction)
+	}
+
+	excerpts := c.allExcerpt()
+
+	var sorter sort.Interface
+
+	switch order {
+	case OrderByCreation:
+		sorter = BugsByCreationTime(excerpts)
+	case OrderByEdit:
+		sorter = BugsByEditTime(excerpts)
+	default:
+		panic("missing sort type")
+	}
+
+	if direction == OrderDescending {
+		sorter = sort.Reverse(sorter)
+	}
+
+	sort.Sort(sorter)
+
+	result := make([]string, len(excerpts))
+
+	for i, val := range excerpts {
+		result[i] = val.Id
+	}
+
+	return result
+}
+
+func (c *RepoCache) orderIds(direction OrderDirection) []string {
+	result := make([]string, len(c.excerpts))
+
+	i := 0
+	for key := range c.excerpts {
+		result[i] = key
+		i++
+	}
+
+	var sorter sort.Interface = sort.StringSlice(result)
+
+	if direction == OrderDescending {
+		sorter = sort.Reverse(sorter)
+	}
+
+	sort.Sort(sorter)
+
+	return result
+}