diff options
| author | Michael Muré <batolettre@gmail.com> | 2020-06-23 18:02:54 +0200 |
|---|---|---|
| committer | Michael Muré <batolettre@gmail.com> | 2020-06-26 19:14:22 +0200 |
| commit | 88ad7e606f1cbf9e47b968a208e3510f7f9a81c5 (patch) | |
| tree | 00e847500b34c6f9a721c71474993d1c08ae8fb1 /cache | |
| parent | 2dd0dbb1344ae9293aae05346f977b5d5907934b (diff) | |
| download | git-bug-88ad7e606f1cbf9e47b968a208e3510f7f9a81c5.tar.gz | |
repository: remove tie to Bug, improved and reusable testing
- allow the creation of arbitrary Lamport clocks, freeing the way to new entities and removing Bug specific (upper layer) code.
- generalize the memory-only and persisted Lamport clocks behind a common interface
- rework the tests to provide reusable testing code for a Repo, a Clock, a Config, opening a path to add a new Repo implementation more easily
- test previously untested components with those new tests
Note: one problem found during this endeavor is that `identity.Version` also need to store one time + Lamport time for each other Entity (Bug, config, PR ...). This could possibly done without breaking change but it would be much easier to wait for https://github.com/MichaelMure/git-bug-migration to happen.
Diffstat (limited to 'cache')
| -rw-r--r-- | cache/repo_cache.go | 6 | ||||
| -rw-r--r-- | cache/repo_cache_test.go | 6 |
2 files changed, 9 insertions, 3 deletions
diff --git a/cache/repo_cache.go b/cache/repo_cache.go index e70904df..4a6b007f 100644 --- a/cache/repo_cache.go +++ b/cache/repo_cache.go @@ -8,6 +8,7 @@ import ( "io/ioutil" "os" "path" + "path/filepath" "sort" "strconv" "sync" @@ -149,6 +150,11 @@ func (c *RepoCache) lock() error { return err } + err = os.MkdirAll(filepath.Dir(lockPath), 0777) + if err != nil { + return err + } + f, err := os.Create(lockPath) if err != nil { return err diff --git a/cache/repo_cache_test.go b/cache/repo_cache_test.go index 51393dfd..0a333c8f 100644 --- a/cache/repo_cache_test.go +++ b/cache/repo_cache_test.go @@ -11,7 +11,7 @@ import ( func TestCache(t *testing.T) { repo := repository.CreateTestRepo(false) - defer repository.CleanupTestRepos(t, repo) + defer repository.CleanupTestRepos(repo) cache, err := NewRepoCache(repo) require.NoError(t, err) @@ -104,8 +104,8 @@ func TestCache(t *testing.T) { } func TestPushPull(t *testing.T) { - repoA, repoB, remote := repository.SetupReposAndRemote(t) - defer repository.CleanupTestRepos(t, repoA, repoB, remote) + repoA, repoB, remote := repository.SetupReposAndRemote() + defer repository.CleanupTestRepos(repoA, repoB, remote) cacheA, err := NewRepoCache(repoA) require.NoError(t, err) |