aboutsummaryrefslogtreecommitdiffstats
path: root/bug
diff options
context:
space:
mode:
authorMichael Muré <batolettre@gmail.com>2020-02-08 16:17:15 +0100
committerMichael Muré <batolettre@gmail.com>2020-02-08 16:17:15 +0100
commit97bc5ccd229b7b438262a84e3c42783b4d4a82af (patch)
tree6e5ef89c8ecce28599e9623d441a18406b2f2f93 /bug
parent77dc783fcb64adf67d10fc3232c4f06f8e3d5392 (diff)
downloadgit-bug-97bc5ccd229b7b438262a84e3c42783b4d4a82af.tar.gz
various cleanups suggested by golang-ci
Diffstat (limited to 'bug')
-rw-r--r--bug/interface.go6
-rw-r--r--bug/op_edit_comment.go9
2 files changed, 6 insertions, 9 deletions
diff --git a/bug/interface.go b/bug/interface.go
index 796ee569..5c8f2729 100644
--- a/bug/interface.go
+++ b/bug/interface.go
@@ -46,11 +46,11 @@ type Interface interface {
}
func bugFromInterface(bug Interface) *Bug {
- switch bug.(type) {
+ switch bug := bug.(type) {
case *Bug:
- return bug.(*Bug)
+ return bug
case *WithSnapshot:
- return bug.(*WithSnapshot).Bug
+ return bug.Bug
default:
panic("missing type case")
}
diff --git a/bug/op_edit_comment.go b/bug/op_edit_comment.go
index a37ce8f7..48020421 100644
--- a/bug/op_edit_comment.go
+++ b/bug/op_edit_comment.go
@@ -59,14 +59,11 @@ func (op *EditCommentOperation) Apply(snapshot *Snapshot) {
UnixTime: timestamp.Timestamp(op.UnixTime),
}
- switch target.(type) {
+ switch target := target.(type) {
case *CreateTimelineItem:
- item := target.(*CreateTimelineItem)
- item.Append(comment)
-
+ target.Append(comment)
case *AddCommentTimelineItem:
- item := target.(*AddCommentTimelineItem)
- item.Append(comment)
+ target.Append(comment)
}
// Updating the corresponding comment