aboutsummaryrefslogtreecommitdiffstats
path: root/bug
diff options
context:
space:
mode:
authorCyril Roelandt <tipecaml@gmail.com>2018-12-22 04:36:32 +0100
committerCyril Roelandt <tipecaml@gmail.com>2018-12-26 23:23:07 +0100
commit11e04748b93621a7d377d3163381ff1f38e5fdbe (patch)
treee19b418a848b50509fe6181648a4d75336c70157 /bug
parent32b3e263fc8443f6089b9de8fbce833369461982 (diff)
downloadgit-bug-11e04748b93621a7d377d3163381ff1f38e5fdbe.tar.gz
Allow empty messages in comments.
Some bug trackers, like Launchpad, allow messages to be empty (when adding a file to the bug, for instance).
Diffstat (limited to 'bug')
-rw-r--r--bug/op_add_comment.go4
-rw-r--r--bug/operation_test.go1
2 files changed, 0 insertions, 5 deletions
diff --git a/bug/op_add_comment.go b/bug/op_add_comment.go
index c19b9593..2d6fb21a 100644
--- a/bug/op_add_comment.go
+++ b/bug/op_add_comment.go
@@ -58,10 +58,6 @@ func (op *AddCommentOperation) Validate() error {
return err
}
- if text.Empty(op.Message) {
- return fmt.Errorf("message is empty")
- }
-
if !text.Safe(op.Message) {
return fmt.Errorf("message is not fully printable")
}
diff --git a/bug/operation_test.go b/bug/operation_test.go
index 9296e247..255d6d98 100644
--- a/bug/operation_test.go
+++ b/bug/operation_test.go
@@ -47,7 +47,6 @@ func TestValidate(t *testing.T) {
NewSetTitleOp(rene, unix, "title", "multi\nline"),
NewSetTitleOp(rene, unix, "title\u001b", "title2"),
NewSetTitleOp(rene, unix, "title", "title2\u001b"),
- NewAddCommentOp(rene, unix, "", nil),
NewAddCommentOp(rene, unix, "message\u001b", nil),
NewAddCommentOp(rene, unix, "message", []git.Hash{git.Hash("invalid")}),
NewSetStatusOp(rene, unix, 1000),