diff options
| author | Michael Muré <batolettre@gmail.com> | 2020-06-23 18:02:54 +0200 |
|---|---|---|
| committer | Michael Muré <batolettre@gmail.com> | 2020-06-26 19:14:22 +0200 |
| commit | 88ad7e606f1cbf9e47b968a208e3510f7f9a81c5 (patch) | |
| tree | 00e847500b34c6f9a721c71474993d1c08ae8fb1 /bridge | |
| parent | 2dd0dbb1344ae9293aae05346f977b5d5907934b (diff) | |
| download | git-bug-88ad7e606f1cbf9e47b968a208e3510f7f9a81c5.tar.gz | |
repository: remove tie to Bug, improved and reusable testing
- allow the creation of arbitrary Lamport clocks, freeing the way to new entities and removing Bug specific (upper layer) code.
- generalize the memory-only and persisted Lamport clocks behind a common interface
- rework the tests to provide reusable testing code for a Repo, a Clock, a Config, opening a path to add a new Repo implementation more easily
- test previously untested components with those new tests
Note: one problem found during this endeavor is that `identity.Version` also need to store one time + Lamport time for each other Entity (Bug, config, PR ...). This could possibly done without breaking change but it would be much easier to wait for https://github.com/MichaelMure/git-bug-migration to happen.
Diffstat (limited to 'bridge')
| -rw-r--r-- | bridge/github/export_test.go | 4 | ||||
| -rw-r--r-- | bridge/github/import_test.go | 2 | ||||
| -rw-r--r-- | bridge/gitlab/export_test.go | 4 | ||||
| -rw-r--r-- | bridge/gitlab/import_test.go | 2 |
4 files changed, 6 insertions, 6 deletions
diff --git a/bridge/github/export_test.go b/bridge/github/export_test.go index 0748ecbf..b160ac7f 100644 --- a/bridge/github/export_test.go +++ b/bridge/github/export_test.go @@ -138,7 +138,7 @@ func TestPushPull(t *testing.T) { // create repo backend repo := repository.CreateTestRepo(false) - defer repository.CleanupTestRepos(t, repo) + defer repository.CleanupTestRepos(repo) backend, err := cache.NewRepoCache(repo) require.NoError(t, err) @@ -210,7 +210,7 @@ func TestPushPull(t *testing.T) { fmt.Printf("test repository exported in %f seconds\n", time.Since(start).Seconds()) repoTwo := repository.CreateTestRepo(false) - defer repository.CleanupTestRepos(t, repoTwo) + defer repository.CleanupTestRepos(repoTwo) // create a second backend backendTwo, err := cache.NewRepoCache(repoTwo) diff --git a/bridge/github/import_test.go b/bridge/github/import_test.go index 107d74c5..f33b30c2 100644 --- a/bridge/github/import_test.go +++ b/bridge/github/import_test.go @@ -128,7 +128,7 @@ func Test_Importer(t *testing.T) { } repo := repository.CreateTestRepo(false) - defer repository.CleanupTestRepos(t, repo) + defer repository.CleanupTestRepos(repo) backend, err := cache.NewRepoCache(repo) require.NoError(t, err) diff --git a/bridge/gitlab/export_test.go b/bridge/gitlab/export_test.go index d8966163..6c151d61 100644 --- a/bridge/gitlab/export_test.go +++ b/bridge/gitlab/export_test.go @@ -143,7 +143,7 @@ func TestPushPull(t *testing.T) { // create repo backend repo := repository.CreateTestRepo(false) - defer repository.CleanupTestRepos(t, repo) + defer repository.CleanupTestRepos(repo) backend, err := cache.NewRepoCache(repo) require.NoError(t, err) @@ -216,7 +216,7 @@ func TestPushPull(t *testing.T) { fmt.Printf("test repository exported in %f seconds\n", time.Since(start).Seconds()) repoTwo := repository.CreateTestRepo(false) - defer repository.CleanupTestRepos(t, repoTwo) + defer repository.CleanupTestRepos(repoTwo) // create a second backend backendTwo, err := cache.NewRepoCache(repoTwo) diff --git a/bridge/gitlab/import_test.go b/bridge/gitlab/import_test.go index 42a37cda..9a936ae4 100644 --- a/bridge/gitlab/import_test.go +++ b/bridge/gitlab/import_test.go @@ -77,7 +77,7 @@ func TestImport(t *testing.T) { } repo := repository.CreateTestRepo(false) - defer repository.CleanupTestRepos(t, repo) + defer repository.CleanupTestRepos(repo) backend, err := cache.NewRepoCache(repo) require.NoError(t, err) |