add unit tests for launchpad bridge configuration

add tests for validateUsername in Github bridge
panic when compile regex fail

2 files changed, 107 insertions, 9 deletions

diff --git a/bridge/launchpad/config.go b/bridge/launchpad/config.go
index 1514505f..d8efea46 100644
--- a/bridge/launchpad/config.go
+++ b/bridge/launchpad/config.go
@@ -2,6 +2,7 @@ package launchpad
 
 import (
 	"bufio"
+	"errors"
 	"fmt"
 	"net/http"
 	"os"
@@ -13,15 +14,13 @@ import (
 	"github.com/MichaelMure/git-bug/repository"
 )
 
+var ErrBadProjectURL = errors.New("bad Launchpad project URL")
+
 const (
 	keyProject     = "project"
 	defaultTimeout = 60 * time.Second
 )
 
-var (
-	rxLaunchpadURL = regexp.MustCompile(`launchpad\.net[\/:]([^\/]*[a-z]+)`)
-)
-
 func (*Launchpad) Configure(repo repository.RepoCommon, params core.BridgeParams) (core.Configuration, error) {
 	if params.Token != "" {
 		fmt.Println("warning: --token is ineffective for a Launchpad bridge")
@@ -39,7 +38,7 @@ func (*Launchpad) Configure(repo repository.RepoCommon, params core.BridgeParams
 
 	} else if params.URL != "" {
 		// get project name from url
-		_, project, err = splitURL(params.URL)
+		project, err = splitURL(params.URL)
 		if err != nil {
 			return nil, err
 		}
@@ -108,11 +107,17 @@ func validateProject(project string) (bool, error) {
 	return resp.StatusCode == http.StatusOK, nil
 }
 
-func splitURL(url string) (string, string, error) {
-	res := rxLaunchpadURL.FindStringSubmatch(url)
+// extract project name from url
+func splitURL(url string) (string, error) {
+	re, err := regexp.Compile(`launchpad\.net[\/:]([^\/]*[a-z]+)`)
+	if err != nil {
+		panic("regexp compile:" + err.Error())
+	}
+
+	res := re.FindStringSubmatch(url)
 	if res == nil {
-		return "", "", fmt.Errorf("bad Launchpad project url")
+		return "", ErrBadProjectURL
 	}
 
-	return res[0], res[1], nil
+	return res[1], nil
 }
diff --git a/bridge/launchpad/config_test.go b/bridge/launchpad/config_test.go
new file mode 100644
index 00000000..275c0d24
--- /dev/null
+++ b/bridge/launchpad/config_test.go
@@ -0,0 +1,93 @@
+package launchpad
+
+import (
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestSplitURL(t *testing.T) {
+	type args struct {
+		url string
+	}
+	type want struct {
+		project string
+		err     error
+	}
+	tests := []struct {
+		name string
+		args args
+		want want
+	}{
+		{
+			name: "default project url",
+			args: args{
+				url: "https://launchpad.net/ubuntu",
+			},
+			want: want{
+				project: "ubuntu",
+				err:     nil,
+			},
+		},
+		{
+			name: "project bugs url",
+			args: args{
+				url: "https://bugs.launchpad.net/ubuntu",
+			},
+			want: want{
+				project: "ubuntu",
+				err:     nil,
+			},
+		},
+		{
+			name: "bad url",
+			args: args{
+				url: "https://launchpa.net/ubuntu",
+			},
+			want: want{
+				err: ErrBadProjectURL,
+			},
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			project, err := splitURL(tt.args.url)
+			assert.Equal(t, tt.want.err, err)
+			assert.Equal(t, tt.want.project, project)
+		})
+	}
+}
+
+func TestValidateProject(t *testing.T) {
+	type args struct {
+		project string
+	}
+	tests := []struct {
+		name string
+		args args
+		want bool
+	}{
+		{
+			name: "public project",
+			args: args{
+				project: "ubuntu",
+			},
+			want: true,
+		},
+		{
+			name: "non existing project",
+			args: args{
+				project: "cant-find-this",
+			},
+			want: false,
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			ok, _ := validateProject(tt.args.project)
+			assert.Equal(t, tt.want, ok)
+		})
+	}
+}