diff options
| author | Alexander Scharinger <rng.dynamics@gmail.com> | 2021-04-08 23:57:25 +0200 |
|---|---|---|
| committer | Alexander Scharinger <rng.dynamics@gmail.com> | 2021-04-08 23:57:25 +0200 |
| commit | 0fd570171d171aa574d7f01d6033a9c01d668465 (patch) | |
| tree | 56a055130e3c2da01cdec080c960977da5738db6 /bridge/github/import.go | |
| parent | ede5e218ac4ae492f06be9d3bb8a1e9463eda739 (diff) | |
| download | git-bug-0fd570171d171aa574d7f01d6033a9c01d668465.tar.gz | |
Improve feedback for user when Github rate limiting
The Github bridge itself should not write anything. This commit removes
code writing to stdout and itroduces an event `ImportEventRateLimiting`
to `core.ImportResult` in order to inform about a rate limiting situation
of the Github GraphQL API. Now the communication with the user is
delegated to the various user interfaces.
Diffstat (limited to 'bridge/github/import.go')
| -rw-r--r-- | bridge/github/import.go | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/bridge/github/import.go b/bridge/github/import.go index 66710d0f..e89f34c4 100644 --- a/bridge/github/import.go +++ b/bridge/github/import.go @@ -79,8 +79,8 @@ func (gi *githubImporter) ImportAll(ctx context.Context, repo *cache.RepoCache, nextEvent = gi.getEventHandleMsgs() switch event := currEvent.(type) { - case MessageEvent: - fmt.Println(event.msg) + case RateLimitingEvent: + out <- core.NewImportRateLimiting(event.msg) case IssueEvent: // first: commit what is being held in currBug if err = gi.commit(currBug, out); err != nil { @@ -148,9 +148,9 @@ func (gi *githubImporter) getEventHandleMsgs() ImportEvent { for { // read event from import mediator event := gi.mediator.NextImportEvent() - // consume (and use) all message events - if e, ok := event.(MessageEvent); ok { - fmt.Println(e.msg) + // consume (and use) all rate limiting events + if e, ok := event.(RateLimitingEvent); ok { + gi.out <- core.NewImportRateLimiting(e.msg) continue } return event |