diff options
author | Steve Moyer <smoyer1@selesy.com> | 2023-01-19 20:29:33 -0500 |
---|---|---|
committer | Steve Moyer <smoyer1@selesy.com> | 2023-01-19 20:29:33 -0500 |
commit | 14773b16ca4a16cbf84416894e254e41a01764b1 (patch) | |
tree | 65470141e2e273a4d33d737719eb97ea294fbe18 | |
parent | cf382e0fad77e758898e7d51c4e322645fb6042c (diff) | |
download | git-bug-14773b16ca4a16cbf84416894e254e41a01764b1.tar.gz |
style: resolve PR comments
-rw-r--r-- | commands/bug/bug_label_new.go | 4 | ||||
-rw-r--r-- | commands/bug/bug_label_rm.go | 4 | ||||
-rw-r--r-- | commands/bug/bug_show.go | 2 | ||||
-rw-r--r-- | commands/bug/completion.go | 4 |
4 files changed, 4 insertions, 10 deletions
diff --git a/commands/bug/bug_label_new.go b/commands/bug/bug_label_new.go index 1e1f2d4f..c8c3b811 100644 --- a/commands/bug/bug_label_new.go +++ b/commands/bug/bug_label_new.go @@ -22,13 +22,11 @@ func newBugLabelNewCommand(env *execenv.Env) *cobra.Command { } func runBugLabelNew(env *execenv.Env, args []string) error { - b, args, err := ResolveSelected(env.Backend, args) + b, added, err := ResolveSelected(env.Backend, args) if err != nil { return err } - added := args - changes, _, err := b.ChangeLabels(text.CleanupOneLineArray(added), nil) for _, change := range changes { diff --git a/commands/bug/bug_label_rm.go b/commands/bug/bug_label_rm.go index 6dda007c..fca2ac46 100644 --- a/commands/bug/bug_label_rm.go +++ b/commands/bug/bug_label_rm.go @@ -22,13 +22,11 @@ func newBugLabelRmCommand(env *execenv.Env) *cobra.Command { } func runBugLabelRm(env *execenv.Env, args []string) error { - b, args, err := ResolveSelected(env.Backend, args) + b, removed, err := ResolveSelected(env.Backend, args) if err != nil { return err } - removed := args - changes, _, err := b.ChangeLabels(nil, text.CleanupOneLineArray(removed)) for _, change := range changes { diff --git a/commands/bug/bug_show.go b/commands/bug/bug_show.go index 38eda54a..ef20df2a 100644 --- a/commands/bug/bug_show.go +++ b/commands/bug/bug_show.go @@ -91,8 +91,6 @@ func runBugShow(env *execenv.Env, opts bugShowOptions, args []string) error { case "title": env.Out.Printf("%s\n", snap.Title) default: - env.Out.Println() - return fmt.Errorf("unsupported field: %s", opts.fields) } diff --git a/commands/bug/completion.go b/commands/bug/completion.go index 4754f97d..62bf658a 100644 --- a/commands/bug/completion.go +++ b/commands/bug/completion.go @@ -50,7 +50,7 @@ func BugAndLabelsCompletion(env *execenv.Env, addOrRemove bool) completion.Valid _ = env.Backend.Close() }() - b, args, err := ResolveSelected(env.Backend, args) + b, cleanArgs, err := ResolveSelected(env.Backend, args) if _select.IsErrNoValidId(err) { // we need a bug first to complete labels return bugWithBackend(env.Backend, toComplete) @@ -62,7 +62,7 @@ func BugAndLabelsCompletion(env *execenv.Env, addOrRemove bool) completion.Valid snap := b.Snapshot() seenLabels := map[bug.Label]bool{} - for _, label := range args { + for _, label := range cleanArgs { seenLabels[bug.Label(label)] = addOrRemove } |