aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichael Muré <batolettre@gmail.com>2018-07-14 23:03:43 +0200
committerMichael Muré <batolettre@gmail.com>2018-07-14 23:03:43 +0200
commit54b41c604bd6814e1bc8131cb1fa291d8aff25d1 (patch)
treefb734ba3af6796ee90a5dc1945885e213a04e950
parent13d7b3480b0f555294edf2c52a886321bbd9f5e8 (diff)
downloadgit-bug-54b41c604bd6814e1bc8131cb1fa291d8aff25d1.tar.gz
cleaning
-rw-r--r--bug/operations/create_test.go2
-rw-r--r--bug/operations/set_title.go2
-rw-r--r--bug/person.go19
-rw-r--r--tests/bug_test.go2
4 files changed, 5 insertions, 20 deletions
diff --git a/bug/operations/create_test.go b/bug/operations/create_test.go
index bd73fc1a..c262a41c 100644
--- a/bug/operations/create_test.go
+++ b/bug/operations/create_test.go
@@ -26,6 +26,6 @@ func TestCreate(t *testing.T) {
}
if !reflect.DeepEqual(snapshot, expected) {
- t.Fatalf("%s different than %s", snapshot, expected)
+ t.Fatalf("%v different than %v", snapshot, expected)
}
}
diff --git a/bug/operations/set_title.go b/bug/operations/set_title.go
index 39f4b332..6d5cb87f 100644
--- a/bug/operations/set_title.go
+++ b/bug/operations/set_title.go
@@ -6,7 +6,7 @@ var _ bug.Operation = SetTitleOperation{}
type SetTitleOperation struct {
bug.OpBase
- Title string `json:"t"`
+ Title string
}
func NewSetTitleOp(title string) SetTitleOperation {
diff --git a/bug/person.go b/bug/person.go
index 9541dbd8..5c9dcc4c 100644
--- a/bug/person.go
+++ b/bug/person.go
@@ -1,15 +1,13 @@
package bug
import (
- "encoding/json"
"errors"
"github.com/MichaelMure/git-bug/repository"
- "github.com/MichaelMure/git-bug/util"
)
type Person struct {
- Name string `json:"name"`
- Email string `json:"email"`
+ Name string
+ Email string
}
// GetUser will query the repository for user detail and build the corresponding Person
@@ -32,16 +30,3 @@ func GetUser(repo repository.Repo) (Person, error) {
return Person{Name: name, Email: email}, nil
}
-
-// Store will convert the Person to JSON and store it in the internal git datastore
-// Return the git hash handle of the data
-func (person *Person) Store(repo repository.Repo) (util.Hash, error) {
-
- data, err := json.Marshal(person)
-
- if err != nil {
- return "", err
- }
-
- return repo.StoreData(data)
-}
diff --git a/tests/bug_test.go b/tests/bug_test.go
index 2fb79be5..62166723 100644
--- a/tests/bug_test.go
+++ b/tests/bug_test.go
@@ -68,6 +68,6 @@ func TestBugSerialisation(t *testing.T) {
}
if !reflect.DeepEqual(bug1, bug2) {
- t.Fatalf("%s different than %s", bug1, bug2)
+ t.Fatalf("%v different than %v", bug1, bug2)
}
}