From 37195a33108299504f8d37042dec06df0540d0d2 Mon Sep 17 00:00:00 2001 From: "W. Trevor King" Date: Mon, 22 Jun 2009 17:31:13 -0400 Subject: Consolidated outstanding bugs. Only one live bug left: 7ec2c071-9630-42b0-b08a-9854616f9144 I've decided (mostly due to the huge Trac post, see bug comments) to _not_ hardcode dependencies, but to add an attribute-creation mechanism that a becommand/depend.py could use for dependency tracking. Time for a new branch to think this out... --- .../401950a0-a5ff-46f3-afac-a9cfb300f94b/body | 39 +++++++++++++++ .../401950a0-a5ff-46f3-afac-a9cfb300f94b/values | 8 ++++ .../6010e186-0260-44e5-8442-8df2269910ce/body | 5 ++ .../6010e186-0260-44e5-8442-8df2269910ce/values | 11 +++++ .../bb988ed4-d3d5-4e49-b67e-c7ccb8ae44d3/body | 47 ++++++++++++++++++ .../bb988ed4-d3d5-4e49-b67e-c7ccb8ae44d3/values | 11 +++++ .../c2b78df3-641a-4d4d-ba94-33b26eda6364/body | 3 ++ .../c2b78df3-641a-4d4d-ba94-33b26eda6364/values | 11 +++++ .../ec133a4e-c9ff-4499-b469-cb0a2ca9a685/body | 55 ++++++++++++++++++++++ .../ec133a4e-c9ff-4499-b469-cb0a2ca9a685/values | 11 +++++ .../f87fd684-6af1-498d-98d5-f915bcee76a9/body | 1 + .../f87fd684-6af1-498d-98d5-f915bcee76a9/values | 8 ++++ .../7ec2c071-9630-42b0-b08a-9854616f9144/values | 31 ++---------- 13 files changed, 215 insertions(+), 26 deletions(-) create mode 100644 .be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/401950a0-a5ff-46f3-afac-a9cfb300f94b/body create mode 100644 .be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/401950a0-a5ff-46f3-afac-a9cfb300f94b/values create mode 100644 .be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/6010e186-0260-44e5-8442-8df2269910ce/body create mode 100644 .be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/6010e186-0260-44e5-8442-8df2269910ce/values create mode 100644 .be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/bb988ed4-d3d5-4e49-b67e-c7ccb8ae44d3/body create mode 100644 .be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/bb988ed4-d3d5-4e49-b67e-c7ccb8ae44d3/values create mode 100644 .be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/c2b78df3-641a-4d4d-ba94-33b26eda6364/body create mode 100644 .be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/c2b78df3-641a-4d4d-ba94-33b26eda6364/values create mode 100644 .be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/ec133a4e-c9ff-4499-b469-cb0a2ca9a685/body create mode 100644 .be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/ec133a4e-c9ff-4499-b469-cb0a2ca9a685/values create mode 100644 .be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/f87fd684-6af1-498d-98d5-f915bcee76a9/body create mode 100644 .be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/f87fd684-6af1-498d-98d5-f915bcee76a9/values (limited to '.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144') diff --git a/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/401950a0-a5ff-46f3-afac-a9cfb300f94b/body b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/401950a0-a5ff-46f3-afac-a9cfb300f94b/body new file mode 100644 index 0000000..6ad8230 --- /dev/null +++ b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/401950a0-a5ff-46f3-afac-a9cfb300f94b/body @@ -0,0 +1,39 @@ +In my Tue, 25 Nov 2008 08:30:19 -0500 email: + +Implemented as a free-form value field similar to target? A +comma-seperated list of tags? Perhaps once we have per-bug/comment +attribute searching it would be easier to have a 'create-attribute' +becommand, e.g. + be create-attribute [-valid=X,Y,Z] [bugdir|bug|comment] [NAME] [DEFAULT] + +We could ship some suggested configuration scripts to set people up, +and keep the core code more general/flexible. + + +Plan: + +Extend and make more consitent the settings_property() attributes. +Create becommand/(create/remove)-attribute for logic-less attributes. +Create a few mix-ins for logic-ed attributes + +Usage example: + Goal: + set up for `be depends BUGA BUGB`, `be depends --tree BUGA`, etc + Procedure: + be set --apend mixins bug:dependency + Where we've defined + becommands/depends.py, but it is hidden until the mixin is activated + libbe/mixins/bug/dependency.Mixin (inheriting from BugMixin) + to + parse/generate comma seperated dependency uuids for saving/loading + pretty-print the dependency list (e.g. uuid->shortname) + walk the dependency tree and check target bug status. + +With more complicated mixins, there could be inter-mixin dependencies, +e.g. a dependency tracker that searches depends based on bug.status +might depend on the base dependency mixin. This way people who need +it could make rich interfaces without confusing the people who don't. + +How does that sound? + + diff --git a/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/401950a0-a5ff-46f3-afac-a9cfb300f94b/values b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/401950a0-a5ff-46f3-afac-a9cfb300f94b/values new file mode 100644 index 0000000..4d945d0 --- /dev/null +++ b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/401950a0-a5ff-46f3-afac-a9cfb300f94b/values @@ -0,0 +1,8 @@ +Content-type: text/plain + + +Date: Mon, 22 Jun 2009 20:39:39 +0000 + + +From: W. Trevor King + diff --git a/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/6010e186-0260-44e5-8442-8df2269910ce/body b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/6010e186-0260-44e5-8442-8df2269910ce/body new file mode 100644 index 0000000..33638ab --- /dev/null +++ b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/6010e186-0260-44e5-8442-8df2269910ce/body @@ -0,0 +1,5 @@ +It's tricky to say whether we should have dependencies or reverse dependencies +or both. + +In the case where a bug is removed, normal dependencies mean that its +dependencies are erased from this system. diff --git a/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/6010e186-0260-44e5-8442-8df2269910ce/values b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/6010e186-0260-44e5-8442-8df2269910ce/values new file mode 100644 index 0000000..98b7985 --- /dev/null +++ b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/6010e186-0260-44e5-8442-8df2269910ce/values @@ -0,0 +1,11 @@ +Content-type: text/plain + + +Date: Mon, 17 Apr 2006 20:59:15 +0000 + + +From: abentley + + +In-reply-to: f87fd684-6af1-498d-98d5-f915bcee76a9 + diff --git a/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/bb988ed4-d3d5-4e49-b67e-c7ccb8ae44d3/body b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/bb988ed4-d3d5-4e49-b67e-c7ccb8ae44d3/body new file mode 100644 index 0000000..57439b7 --- /dev/null +++ b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/bb988ed4-d3d5-4e49-b67e-c7ccb8ae44d3/body @@ -0,0 +1,47 @@ +From my Tue, 25 Nov 2008 13:27:12 -0500 email: + +> >> 7ec:om: Arbitrary tags +> >> Sensible +> > +> > Implemented as a free-form value field similar to target? A +> > comma-seperated list of tags? +> + +That is a much better format than my unmergable one ;). + +> "append" usually has two "p"s. Is the omission deliberate? + +Nope, sorry :p + +> It sounds pretty complicated. I would probably use a type system rather +> than "mixins", and define types as "scalar", "set" and maybe "list" and +> "map". Dependencies would be a set, and their special behaviour would +> be hardcoded according to their name, not a property of their type. + +Ok. I'm just worried about bloat. It's pretty easy to move things +around at the moment, but I'm worried that adding lots of attributes +with special code will start a slippery slope of trying to satisfy +everybody internally. Then things start looking more like Arch, with +newbies scared off by the confusion. I know the Arch people like the +power, but it took me several hours to figure out how to create a +repository ;). Some people like bug dependencies, and some do not + e.g. + https://bugs.launchpad.net/malone/+bug/95419 + http://trac.edgewall.org/ticket/31 + +From the *long* Trac post, you can see that this is divisive issue. + +I would be in favor of emulating TracCrossReferences +(http://trac.edgewall.org/wiki/TracCrossReferences) in our core. We +could have references and backlinks fields for bugs (and comments?). +But I'd rather not add blocking, etc. However, having a seperate +plugin obviously doesn't work for some people ;). We'd like to bundle +lots of functionality, but keep the core fairly clean and flexible. + +Therefore, I'd like a way to put non-core implememtation code in a +seperate submod. We already call our libbe code "plugins", and we're +extending the builtin BugDir, Bug, etc code, so I thought we'd call +the non-core submods mixins (see http://en.wikipedia.org/wiki/Mixin). + +Anyhow, just my 2c. + diff --git a/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/bb988ed4-d3d5-4e49-b67e-c7ccb8ae44d3/values b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/bb988ed4-d3d5-4e49-b67e-c7ccb8ae44d3/values new file mode 100644 index 0000000..3754f28 --- /dev/null +++ b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/bb988ed4-d3d5-4e49-b67e-c7ccb8ae44d3/values @@ -0,0 +1,11 @@ +Content-type: text/plain + + +Date: Mon, 22 Jun 2009 20:42:12 +0000 + + +From: W. Trevor King + + +In-reply-to: ec133a4e-c9ff-4499-b469-cb0a2ca9a685 + diff --git a/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/c2b78df3-641a-4d4d-ba94-33b26eda6364/body b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/c2b78df3-641a-4d4d-ba94-33b26eda6364/body new file mode 100644 index 0000000..4ac7a33 --- /dev/null +++ b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/c2b78df3-641a-4d4d-ba94-33b26eda6364/body @@ -0,0 +1,3 @@ +This could be implemented with an external frontend storing the +dependency data in arbitrary tags. + diff --git a/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/c2b78df3-641a-4d4d-ba94-33b26eda6364/values b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/c2b78df3-641a-4d4d-ba94-33b26eda6364/values new file mode 100644 index 0000000..11fb7b0 --- /dev/null +++ b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/c2b78df3-641a-4d4d-ba94-33b26eda6364/values @@ -0,0 +1,11 @@ +Content-type: text/plain + + +Date: Mon, 22 Jun 2009 21:29:13 +0000 + + +From: W. Trevor King + + +In-reply-to: f87fd684-6af1-498d-98d5-f915bcee76a9 + diff --git a/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/ec133a4e-c9ff-4499-b469-cb0a2ca9a685/body b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/ec133a4e-c9ff-4499-b469-cb0a2ca9a685/body new file mode 100644 index 0000000..a06e236 --- /dev/null +++ b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/ec133a4e-c9ff-4499-b469-cb0a2ca9a685/body @@ -0,0 +1,55 @@ +In Aaron's Tue, 25 Nov 2008 09:32:29 -0500 email: + +>> 7ec:om: Arbitrary tags +>> Sensible +> +> Implemented as a free-form value field similar to target? A +> comma-seperated list of tags? + +I believe I planned to store it as an alpha-sorted, one-entry-per-line +list, so it would support merging easily. + +> Perhaps once we have per-bug/comment +> attribute searching it would be easier to have a 'create-attribute' +> becommand, e.g. +> be create-attribute [-valid=X,Y,Z] [bugdir|bug|comment] [NAME] [DEFAULT] + +Well, it really depends how much semantics you want to embed in the data +format. Some values are scalars, some may be sets (i.e. tags), some may +be ordered lists or even mappings. How much you want to reflect that in +the data format is up to you. + +> Extend and make more consitent the settings_property() attributes. +> Create becommand/(create/remove)-attribute for logic-less attributes. +> Create a few mix-ins for logic-ed attributes + +I don't find the term mix-in very intuitive here. + +> Usage example: +> Goal: +> set up for `be depends BUGA BUGB`, `be depends --tree BUGA`, etc +> Procedure: +> be set --apend mixins bug:dependency + +"append" usually has two "p"s. Is the omission deliberate? + +> Where we've defined +> becommands/depends.py, but it is hidden until the mixin is activated +> libbe/mixins/bug/dependency.Mixin (inheriting from BugMixin) +> to +> parse/generate comma seperated dependency uuids for saving/loading +> pretty-print the dependency list (e.g. uuid->shortname) +> walk the dependency tree and check target bug status. +> +> With more complicated mixins, there could be inter-mixin dependencies, +> e.g. a dependency tracker that searches depends based on bug.status +> might depend on the base dependency mixin. This way people who need +> it could make rich interfaces without confusing the people who don't. +> +> How does that sound? + +It sounds pretty complicated. I would probably use a type system rather +than "mixins", and define types as "scalar", "set" and maybe "list" and +"map". Dependencies would be a set, and their special behaviour would +be hardcoded according to their name, not a property of their type. + diff --git a/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/ec133a4e-c9ff-4499-b469-cb0a2ca9a685/values b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/ec133a4e-c9ff-4499-b469-cb0a2ca9a685/values new file mode 100644 index 0000000..9078dd6 --- /dev/null +++ b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/ec133a4e-c9ff-4499-b469-cb0a2ca9a685/values @@ -0,0 +1,11 @@ +Content-type: text/plain + + +Date: Mon, 22 Jun 2009 20:40:54 +0000 + + +From: W. Trevor King + + +In-reply-to: 401950a0-a5ff-46f3-afac-a9cfb300f94b + diff --git a/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/f87fd684-6af1-498d-98d5-f915bcee76a9/body b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/f87fd684-6af1-498d-98d5-f915bcee76a9/body new file mode 100644 index 0000000..a28cfe4 --- /dev/null +++ b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/f87fd684-6af1-498d-98d5-f915bcee76a9/body @@ -0,0 +1 @@ +Merged from bug 17921fbc-e7f0-4f31-8cdd-598e5ba7237b \ No newline at end of file diff --git a/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/f87fd684-6af1-498d-98d5-f915bcee76a9/values b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/f87fd684-6af1-498d-98d5-f915bcee76a9/values new file mode 100644 index 0000000..0465a85 --- /dev/null +++ b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/comments/f87fd684-6af1-498d-98d5-f915bcee76a9/values @@ -0,0 +1,8 @@ +Content-type: text/plain + + +Date: Mon, 22 Jun 2009 21:29:32 +0000 + + +From: W. Trevor King + diff --git a/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/values b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/values index 355e32e..07811f7 100644 --- a/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/values +++ b/.be/bugs/7ec2c071-9630-42b0-b08a-9854616f9144/values @@ -1,35 +1,14 @@ +creator: abentley +severity: minor -creator=abentley +status: open +summary: Arbitrary tags - -severity=minor - - - - - - -status=open - - - - - - -summary=Arbitrary tags - - - - - - -time=Wed, 04 Jan 2006 21:06:38 +0000 - - +time: Wed, 04 Jan 2006 21:06:38 +0000 -- cgit