From 148379492d314c0eb98ee8559aea7a2fd0baaeb2 Mon Sep 17 00:00:00 2001 From: "W. Trevor King" Date: Mon, 1 Feb 2010 10:59:52 -0500 Subject: Clearer UnicodeDecodeError message in command_line.dispatch(). See #bea/e30# ("Where should the vcs-name and encoding configuration options live?") for details. --- .../e7d8343a-bd85-4359-bcda-bf0dc1e8177a/body | 42 ++++++++++++++++++++++ .../e7d8343a-bd85-4359-bcda-bf0dc1e8177a/values | 11 ++++++ .../628a050a-f969-4290-8468-f5e991528f40/body | 11 ++++++ .../628a050a-f969-4290-8468-f5e991528f40/values | 11 ++++++ .../2cd562f5-fcb9-4cc5-bf8c-ad5c9d960761/body | 15 ++++++++ .../2cd562f5-fcb9-4cc5-bf8c-ad5c9d960761/values | 8 +++++ .../68ec74b9-d2c7-421f-ac70-602b43bbd263/body | 5 +++ .../68ec74b9-d2c7-421f-ac70-602b43bbd263/values | 11 ++++++ .../e30e2b6b-acc9-4b93-88c6-b63b6e30b593/values | 17 +++++++++ 9 files changed, 131 insertions(+) create mode 100644 .be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/3438b72c-6244-4f1d-8722-8c8d41484e35/comments/e7d8343a-bd85-4359-bcda-bf0dc1e8177a/body create mode 100644 .be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/3438b72c-6244-4f1d-8722-8c8d41484e35/comments/e7d8343a-bd85-4359-bcda-bf0dc1e8177a/values create mode 100644 .be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/5fb11e65-68a0-4015-b404-737238299cdc/comments/628a050a-f969-4290-8468-f5e991528f40/body create mode 100644 .be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/5fb11e65-68a0-4015-b404-737238299cdc/comments/628a050a-f969-4290-8468-f5e991528f40/values create mode 100644 .be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/comments/2cd562f5-fcb9-4cc5-bf8c-ad5c9d960761/body create mode 100644 .be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/comments/2cd562f5-fcb9-4cc5-bf8c-ad5c9d960761/values create mode 100644 .be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/comments/68ec74b9-d2c7-421f-ac70-602b43bbd263/body create mode 100644 .be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/comments/68ec74b9-d2c7-421f-ac70-602b43bbd263/values create mode 100644 .be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/values (limited to '.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs') diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/3438b72c-6244-4f1d-8722-8c8d41484e35/comments/e7d8343a-bd85-4359-bcda-bf0dc1e8177a/body b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/3438b72c-6244-4f1d-8722-8c8d41484e35/comments/e7d8343a-bd85-4359-bcda-bf0dc1e8177a/body new file mode 100644 index 0000000..b6a0435 --- /dev/null +++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/3438b72c-6244-4f1d-8722-8c8d41484e35/comments/e7d8343a-bd85-4359-bcda-bf0dc1e8177a/body @@ -0,0 +1,42 @@ +> It would be nice if we could store tests. +> .be/BUGDIR/tests/... +> and link them from bugs. + +Better: have them be comments with a TEST tag. + +The mime type could hint at the execution mechanism: + text/x-python + application/x-sh + ... + +> Then running +> test.py BUGDIR/BUG +> would run the tests for that particular bug. +> +> This would provide regression testing via +> test.py $(be list --ids --status fixed) + +This should be a 'test' command (libbe.command.test.Test), since +people will want to test bugs for their own projects, and out current +test.py is for testing BE specifically. It should be + be test BUGDIR/BUG + be test $(be list --ids --status fixed) + +We _should_ add be + test $(be list --ids --status fixed) +to test.py for regression testing. + +This whole thing would make the fixed/closed distinction more clear, +since fixed bugs would get tests run and expect success, while closed +bugs' tests would be skipped. + +Finally, if users are submitting tests on their own, it would be a +good idea to sandbox them, but a portable way for sandboxing scripts +sounds very complicated. It would probably be easier to sandbox +python scripts, but I don't know what that would look like... + +A work around would be to allow users to post tests, but not allow +them to set the TEST flag. Then the bugdir maintainer could set the +flag themselves once they'd vetted the test. Much uglier than +sandboxing, but also much more easily implemented. + diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/3438b72c-6244-4f1d-8722-8c8d41484e35/comments/e7d8343a-bd85-4359-bcda-bf0dc1e8177a/values b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/3438b72c-6244-4f1d-8722-8c8d41484e35/comments/e7d8343a-bd85-4359-bcda-bf0dc1e8177a/values new file mode 100644 index 0000000..3ddceba --- /dev/null +++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/3438b72c-6244-4f1d-8722-8c8d41484e35/comments/e7d8343a-bd85-4359-bcda-bf0dc1e8177a/values @@ -0,0 +1,11 @@ +Author: W. Trevor King + + +Content-type: text/plain + + +Date: Sun, 31 Jan 2010 17:36:52 +0000 + + +In-reply-to: ba96f1c0-ba48-4df8-aaf0-4e3a3144fc46 + diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/5fb11e65-68a0-4015-b404-737238299cdc/comments/628a050a-f969-4290-8468-f5e991528f40/body b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/5fb11e65-68a0-4015-b404-737238299cdc/comments/628a050a-f969-4290-8468-f5e991528f40/body new file mode 100644 index 0000000..40d9e29 --- /dev/null +++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/5fb11e65-68a0-4015-b404-737238299cdc/comments/628a050a-f969-4290-8468-f5e991528f40/body @@ -0,0 +1,11 @@ +Either of these could be added at the + libbe.command.base.Command.run +level. + +The Git hooks would be 'pre-' and 'post-'. + +Oh, and the hooks are therefore command-level hooks, not storage-level +hooks. We still want storage-level hooks for notification emails, etc, +and they would definately have to follow the Git directory approach. +Hmm. Storage level hooks will be awkward... + diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/5fb11e65-68a0-4015-b404-737238299cdc/comments/628a050a-f969-4290-8468-f5e991528f40/values b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/5fb11e65-68a0-4015-b404-737238299cdc/comments/628a050a-f969-4290-8468-f5e991528f40/values new file mode 100644 index 0000000..decd72f --- /dev/null +++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/5fb11e65-68a0-4015-b404-737238299cdc/comments/628a050a-f969-4290-8468-f5e991528f40/values @@ -0,0 +1,11 @@ +Author: W. Trevor King + + +Content-type: text/plain + + +Date: Sun, 31 Jan 2010 18:04:49 +0000 + + +In-reply-to: f3e90a7e-b8c4-4a7c-8609-6a783ae59762 + diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/comments/2cd562f5-fcb9-4cc5-bf8c-ad5c9d960761/body b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/comments/2cd562f5-fcb9-4cc5-bf8c-ad5c9d960761/body new file mode 100644 index 0000000..30286d3 --- /dev/null +++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/comments/2cd562f5-fcb9-4cc5-bf8c-ad5c9d960761/body @@ -0,0 +1,15 @@ +Before Bugs Everywhere Directory v1.4 we kept + "encoding" + "vcs_name" +and other bugdir-wide configuration options in ./be/settings + +Now we don't store them anymore, but we should keep some. For +example, the encoding setting is useful when running `be html` in a +cron job. The settings are repository wide, so they should _still_ go +in ./be/settings (since there may, eventually, be several bugdirs in a +repo), but who's job is it to read that file? + +The user interface takes care of encoding, but the storage object +would be checking for a bug repository and reading the settings file. +How/when does it notify the UI? + diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/comments/2cd562f5-fcb9-4cc5-bf8c-ad5c9d960761/values b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/comments/2cd562f5-fcb9-4cc5-bf8c-ad5c9d960761/values new file mode 100644 index 0000000..a4a84af --- /dev/null +++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/comments/2cd562f5-fcb9-4cc5-bf8c-ad5c9d960761/values @@ -0,0 +1,8 @@ +Author: W. Trevor King + + +Content-type: text/plain + + +Date: Mon, 01 Feb 2010 14:34:10 +0000 + diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/comments/68ec74b9-d2c7-421f-ac70-602b43bbd263/body b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/comments/68ec74b9-d2c7-421f-ac70-602b43bbd263/body new file mode 100644 index 0000000..fafa132 --- /dev/null +++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/comments/68ec74b9-d2c7-421f-ac70-602b43bbd263/body @@ -0,0 +1,5 @@ +On the other hand, since encoding decisions seem to be locale-driven, +so you can just setup the appropriate locale environmental variables +in your cron job: + export LANG=en_US.utf8 +and that should do it... diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/comments/68ec74b9-d2c7-421f-ac70-602b43bbd263/values b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/comments/68ec74b9-d2c7-421f-ac70-602b43bbd263/values new file mode 100644 index 0000000..4bb296a --- /dev/null +++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/comments/68ec74b9-d2c7-421f-ac70-602b43bbd263/values @@ -0,0 +1,11 @@ +Author: W. Trevor King + + +Content-type: text/plain + + +Date: Mon, 01 Feb 2010 15:35:57 +0000 + + +In-reply-to: 2cd562f5-fcb9-4cc5-bf8c-ad5c9d960761 + diff --git a/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/values b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/values new file mode 100644 index 0000000..4d48446 --- /dev/null +++ b/.be/bea86499-824e-4e77-b085-2d581fa9ccab/bugs/e30e2b6b-acc9-4b93-88c6-b63b6e30b593/values @@ -0,0 +1,17 @@ +creator: W. Trevor King + + +reporter: W. Trevor King + + +severity: minor + + +status: open + + +summary: Where should the vcs-name and encoding configuration options live? + + +time: Mon, 01 Feb 2010 14:28:13 +0000 + -- cgit