aboutsummaryrefslogtreecommitdiffstats
path: root/libbe
Commit message (Collapse)AuthorAgeFilesLines
* Added darcs support.W. Trevor King2009-06-304-9/+184
| | | | | | | | | | | | I don't know much darcs, so I make no claims about the beauty of my implementation. It seems to get the job done though, until a darcs guru comes along. I also tweaked the libbe.git.Git._rcs_get_user_id to handle the case where user.name or user.email are not set. I also added the option to pass a stdin string into the libbe.rcs.RCS._u_invoke* functions.
* Remove blank line from bug.xml() output when bug has no comments.W. Trevor King2009-06-301-2/+2
|
* Added ability to handle non text/* MIME types.W. Trevor King2009-06-267-19/+39
| | | | | | | | | | | | | | | | The main problem was the encoding/decoding that was happening to _all_ input/output. Now many I/O activities have a `binary' option to disable any encoding/decoding. The `binary' flag is set whenever the comment content-type is not a text/* type. In order to print valid XML (and make life easy on xml/be-xml-to-mbox), non text/* types are printed out as base64-encoded MIME messages, so be list --xml | be-xml-to-mbox | catmutt works as you'd expect. With the standard (non-XML) output from `be show', we just print a message telling the user that we can't reasonably display the MIME type and that they should use the XML output if they want to see it.
* Updated help strings, man page, and completionsW. Trevor King2009-06-251-1/+7
|
* Fixed libbe.rcs.RCS.installed to handle missing backend binary.wking2009-06-251-3/+3
| | | | | | | | | This makes all the failed tests understandable, since they all crash with strings like: AssertionError: Arch RCS not found Which makes more sense than spitting out the raw CommandError. It also means that installed_rcs() actually works now ;).
* Added extra_strings functionality to libbe.bug.xml and be-xml-to-mbox.W. Trevor King2009-06-251-1/+2
|
* Fixed settings=None bug when bug values file is blank/missing.W. Trevor King2009-06-251-1/+1
| | | | | | | | | | | Just return an empty dict instead. Steps to reproduce: $ mkdir /tmp/BE-test $ cd /tmp/BE-test $ be set-root $ be new 'having too much fun'
* tag --remove now returns bug.settings["extra_strings"] to EMPTY.W. Trevor King2009-06-253-68/+89
| | | | | | | | | | | | | | | | | | | | | | | | | extra_strings returns to a defaulting property from a cached/generator property, with the help of the new, mutable defaults. Lots of deepcopies avoid mutable default uncertainty too ;). And copy.deepcopy([]) should be pretty cheap. tag --remove had previously left settings["extra_strings"] as [], which polluted the bug's values file. Now the improved defaulting_property notices a return to the default [], and sets the internally stored value to EMPTY. I struggled with creating a more intuitive way to notice changes to extra_strings than the tmp = bug.extra_strings <work on tmp> bug.extra_strings = tmp but didn't have any luck. The problem seems to be that if you only hand out copies of your default, you don't have any pointers to what you handed out to check for changes. On the other hand, if you hand out your original default, any external changes will _change_ your original default. I suppose you could only hand out copies, but keep a list of all copies handed out, but that sounds like a disaster. Reassigning is easy enough.
* Use generator instead of default for libbe.bug.Bug.extra_strings.W. Trevor King2009-06-231-1/+3
| | | | This avoids the problems associated with mutable defaults.
* Added test case for mutables to libbe/settings_object.W. Trevor King2009-06-231-4/+59
| | | | | | | | | | | | | This continues the line of changes started in libbe/properties with the last two commits. Also straightened up stranch double-default in libbe.settings_object.versioned_property and moved the fn_checked before checked, which shouldn't matter because I never use both at once, and can't think of a case where you'd want to. I've also added some docstrings to the settings_object unit tests, since apparently docstrings get printed during the test if they exist, and they look nicer than the name of the unittest itself. More like ./configure output ;).
* Cleaned up libbe.propertied.change_hook_property for mutables.W. Trevor King2009-06-231-15/+97
| | | | | | | | | | | | | | | | | | Now (except for a wimpy hash function) it's as good as it's going to get for true mutables. Calls to change_hook occur for all changes, sometime after the change-enducing action and before the next attribute access. See testChangeHookMutableProperty for an example of the expected behavior. If you're doing some mutable-modification (e.g. t.x.append(5)) and you want to `flush' the changes into a change_hook call, just assign t.x to a dummy variable. e.g. t.x.append(5) dummy = t.x If you _really_ need post-modification change_hook calls without such a flush, you're on your own. Would you get the property-owning class to poll for changes?
* Added Bug.extra_strings to support add-on functionality, e.g. `be tag`.W. Trevor King2009-06-235-12/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Versioned properties whose data is a mutable type are tricky, since the simple comparisons we'd been using in libbe.properties.change_hook_property don't work for mutables. For now, we avoid that problem by assuming a change happened whenever a mutable property is set. change_hook_property is a bit untidy at the moment while I work out how to deal with mutables. As an example of using Bug.extra_strings to patch on some useful functionality, I've written becommands/tag.py. I'd suggest future add-ons (e.g. becommands/depend.py?) use the "<LABEL>:<value>" string format to keep it easy to sort out which strings belong to which add-ons. tag.py is still missing command line tag-removal and tag-searching for `be list'. Perhaps something like be list --extra-strings TAG:<your-tag>,TAG:<another-tag>,DEPEND:<bug-id> would be good, although it would requre escaping commas from the tags, or refusing to allow commas in the tags... libbe.properties.ValueCheckError also got a minor update so the printed error message makes sense when raised with allowed being an iterable (i.e. check_property) or a function (e.g. fn_checked_property). All of this digging around turned up a really buggy libbe.bugdir.MultipleBugMatches. Obviously I had never actually called it before :p. Should be fixed now. libbe.comment._set_comment_body has also been normalized to match the suggested change_hook interface: change_hook(self, old, new). Although, I'm not sure why it hadn't been causing obvious problems before, so maybe I'm misunderstanding something about that.
* Added `be list --sort *` for user-selectable sorting.W. Trevor King2009-06-222-23/+34
| | | | | | | | | | | Also added libbe.bug.cmp_last_modified, which handles part of 9ce2f015-8ea0-43a5-a03d-fc36f6d202fe. To do better we could extend the RCS framework. I also transcribed a few emails from the be-devel list onto their relavent bugs and closed a few bugs. Finally, I removed some left over InvalidValue cruft.
* Use Comment.content_type in xml output.W. Trevor King2009-06-221-0/+2
|
* Only print RFC 2822 date in bug xml output.W. Trevor King2009-06-221-3/+1
|
* Escape XML strings.W. Trevor King2009-06-222-11/+14
| | | | | | Since <creator>John Doe <jdoe@example.com></creator> is not valid XML.
* Fixed libbe.settings_object.EMPTY output in bug/comment XML.W. Trevor King2009-06-222-2/+2
| | | | The xml() method hadn't been updated since the settings_object revamp.
* Adjusted comment XML fields for consistency.W. Trevor King2009-06-221-4/+4
| | | | | Renamed "name" -> "short-name" and "in_reply_to" -> "in-reply-to". Reordered uuid before short-name.
* Touch missing userwide config file before read if it's missing.W. Trevor King2009-06-211-0/+2
| | | | | | | | Another bug introduced by James Rowe's user-config patch. Obviously it's hard to read a file if there's no file there. I'm not sure how it passed the unit tests earlier. Maybe I forgot to install the pre-commit version before running the test suite... Anyhow, fixed now.
* Merge from Ben Finney's RCS unittest patchW. Trevor King2009-06-215-100/+291
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This involved an `upgrade' of BE's bzr repo Previous version (via `bzr info path/to/repo`): pack-0.92 Current version: rich-root-pack The whole rich-root thing is a bzr features-vs-backwards-compatability thing they've been wrestling with [1,2,3,4,...]. It seems that BE was in some sort of unstable equilibrium [5], so I'll follow Ben's lead and make the official switch. Note that you'll need to use bzr>=1.5 to make the shift [6]. For the sake of completeness, the whole rich-root thing was introduced here [7], but I don't understand enough of bzr to make sense of the diff. It just versions the repo's root directory the same way it versions other directories [3]. The bzr people seem to be planning to phase out non-rich-root formats in favor of brisbane-core, aka 2.0beta [8], by bzr 2.0 [8], which is apparently on the horizon [9,10,11]. What a headache. Citations are all titles/X-List-Received-Date from https://lists.ubuntu.com/archives/bazaar/ with the exception of the URL [11]. [1] [RFC] rich root pack as default in 1.8 ? Sat, 06 Sep 2008 03:33:46 -0000 (conclusion: none) [2] Re: 1.9rc1 countdown Thu, 30 Oct 2008 08:44:53 -0000 (conclusion: "primary" format should be rich-root next time we make a new format) [3] So many repo formats Fri, 14 Nov 2008 08:41:33 -0000 Mon, 17 Nov 2008 07:37:47 -0000 (explains rich-root format) Mon, 17 Nov 2008 22:37:39 -0000 (explains no-return policy) Mon, 17 Nov 2008 20:57:08 -0000 (explicitly lists non-svn reasons for rich-root) [4] Branch fails from 'pack-0.92' repo to 'rich-root-pack' repo. Wed, 27 Aug 2008 11:31:11 -0000 (we're not sure again) [5] Branch fails from 'pack-0.92' repo to 'rich-root-pack' repo. Sun, 20 Apr 2008 12:58:09 -0000 [6] Branch fails from 'pack-0.92' repo to 'rich-root-pack' repo. Fri, 29 Aug 2008 13:23:52 -0000 [7] [RFC] Knit format 2 Fri, 25 Aug 2006 22:55:36 -0000 [8] bazaar 2.0beta format for launchpad release Fri, 29 May 2009 06:00:03 -0000 [9] Upgrading loggerhead to 1.9-rich-root Mon, 11 May 2009 22:35:28 -0000 (mentions eventual switch to rich-root in 2.0) [10] bzr 1.16rc1 released! Fri, 12 Jun 2009 08:00:08 -0000 (confirms eventual switch to rich-root in 2.0) [11] https://launchpad.net/bzr/+announcement/2733 (current outstanding releases: 1.17, 2.0)
| * Conform new docstrings to PEP 257.John Doe2009-06-211-63/+21
| |
| * Follow existing docstring whitespace convention.John Doe2009-06-151-21/+63
| |
| * Distinguish tests for VCS which can't handle an uninitialised identity.John Doe2009-06-141-1/+9
| |
| * Refactor mega-testcases into separate true-or-false testcases.John Doe2009-06-141-78/+229
| |
| * Make RCS testcase subclasses dynamically.John Doe2009-06-145-23/+54
| |
* | Allow defaults for config.get_val() in case of missing user-config file.W. Trevor King2009-06-192-14/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes bug introduced by James Rowe's previous patch: $ be list Traceback (most recent call last): ... File ".../libbe/rcs.py", line 34, in _get_matching_rcs import arch File ".../libbe/arch.py", line 29, in <module> client = config.get_val("arch_client") File ".../libbe/config.py", line 70, in get_val File "/usr/lib/python2.5/codecs.py", line 817, in open file = __builtin__.open(filename, mode, buffering) IOError: [Errno 2] No such file or directory: '/home/wking/.bugs_everywhere'
* | Merged James Rowe's arch-shouldn't-create-userwide-config-file patch.James Rowe2009-06-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | From his email to the be-devel list: From: James Rowe <jnrowe@ukfsn.org> Date: Tue, 3 May 2009 11:44:41 +0000 Subject: [PATCH] Don't create config file unless we're using arch. Hi, I find the current behaviour of creating a config file simply to set a default for a revision control system I'm never going to use to be a little annoying, the attached patch changes this behaviour to only set the default in the config file if you're actually using arch. Thanks, James
* | Merged Thomas Habets 2009-01-07 XML output for "be show".W. Trevor King2009-06-194-15/+184
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I rewrote a few of his routines, e.g. generalizing Comment.string_thread to run a caller-specified method avoided the need for some duplicate code in Comment.xml_thread. There was also a reasonable reorganization of libbe.settings_object.versioned_property because the <in_reply_to> field of the Comment.xml output was giving me `-1' (= old settings_object.EMPTY) instead of None, even after I had set comm.in_reply_to to None. The rewritten versioned_property avoids the ambiguity of UNPRIMED vs EMPTY, and avoids the stupididy of my using EMPTY=-1 ;).
| * | XML output for "be show"Thomas Habets2009-01-072-0/+68
| |/
* | Removed unused libbe/restconvert.py and fixed a typo in README.devW. Trevor King2009-06-191-130/+0
| |
* | Merge from main branch.W. Trevor King2009-06-191-1/+1
|\ \
| * | Use a more general regex to test GIT commits; GIT's output has changed.Chris Ball2009-06-131-1/+1
| |/
* | libbe/encoding.pyW. Trevor King2009-06-191-2/+2
| |
* | Fixed lack of user_id caching in bugdir.BugDirW. Trevor King2008-12-041-5/+9
| |
* | Added per-tree default assignee option.W. Trevor King2008-12-041-1/+6
| | | | | | | | | | The new setting is currently only used when creating new bugs with becommand/new.
* | Closed a few old bugs that seem outdated/dealt with.W. Trevor King2008-12-041-1/+1
| |
* | Fixed missing directory error when merging comments onto a bare bug.W. Trevor King2008-12-041-0/+2
| | | | | | | | | | | | | | | | | | If bug_A had no comments (and so, no comment directory), changing comment settings before saving raised missing directory errors. save_settings had previously assumed the .be/bugs/XYZ/comments/ directory existed, which wasn't true for comment-less bugs. Now it checks, and creates the directory if necessary.
* | becommands/severity and status now handle --complete appropriately.W. Trevor King2008-12-041-0/+2
| | | | | | | | | | | | | | | | | | | | I also disabled interspersed options and arguments in cmdutils.CmdOptionParser. See http://docs.python.org/library/optparse.html Now $ be severity xyz --complete returns available severities. It had previously returned --help --complete
* | Per-tree status levels working.W. Trevor King2008-12-043-19/+57
| |
* | bug severity verification now works with per-tree severities.W. Trevor King2008-12-042-6/+8
| | | | | | | | | | | | | | | | | | | | I adjusted the YAML format following http://pyyaml.org/ticket/11 Unicode support To remove '!!python/unicode' escapes and allow unicode in the output. We can always have unicode in the output because the output is encoded (as per the BugFile.encoding setting) before being sent to the outside world.
* | Per-tree settings now passed into bug module.W. Trevor King2008-12-042-7/+27
| | | | | | | | | | | | | | | | becommands/severity gets the configured settings appropriately. Todo: adjust setting-validation to compare against the current values. setup becommands/severity to --complete severities.
* | Added per-tree configurable severities.W. Trevor King2008-12-043-27/+38
| | | | | | | | | | | | | | They currently have no effect, but you can see them with $ be set There's a lot of information in this one 'settings' variable. I think set will have to be specialized to handle arrays smoothly...
* | Added support for bug reporter field.W. Trevor King2008-12-021-0/+1
| | | | | | | | Closes e2f6514c-5f9f-4734-a537-daf3fbe7e9a0
* | Fixed comparison bug in Bug._get_time.W. Trevor King2008-12-021-3/+8
| |
* | Converted Comment to the settings_object system.W. Trevor King2008-12-021-56/+28
| |
* | Bug moved to the settings_object system.W. Trevor King2008-12-021-56/+31
| |
* | Added decorator-style properties to bugdir. Created settings_object module.W. Trevor King2008-12-025-157/+467
| | | | | | | | | | | | | | | | settings_object.SavedSettingsObject encapsulates some of the common settings functionality in the BE BugDir, Bug, and Comment classes. It's a bit awkward due to the nature of scoping in python subclasses, but it's better than reproducing this code in each of the above classes. Now I need to move Bug and Comment over to *this* system ;).
* | Added decorator-style properties to libbe/comment.py.W. Trevor King2008-12-013-77/+209
| | | | | | | | | | Also some typo corrections and some reworking of bug/bugdir to better support the lazier loading.
* | Added libbe/properties to make property management easier.W. Trevor King2008-11-282-105/+586
| | | | | | | | | | libbe/bug has been moved over to the new system. comment and bugdir still to go.
* | Added becommands/comment completion.W. Trevor King2008-11-273-4/+12
| |
generated by cgit (git 2.34.1) at 2024-09-20 19:26:28 +0000