| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| | |
|
| | |
|
| |
|
|
| |
Also added blank lines to separate the new/modified/removed groups.
|
| |
|
|
| |
Fixes bug b3c6da51-3a30-42c9-8c75-587c7a1705c5
|
| |
|
|
|
|
| |
Fixes the duplicate bugs
a403de79-8f39-41f2-b9ec-15053b175ee2
c894f10f-197d-4b22-9c5b-19f394df40d4
|
| | |
|
| | |
|
| |
|
|
| |
Also some minor cleanups.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
Don't use del(rcs), because if there was an error, there is still a
reference to rcs in the traceback, so it is never cleaned up. This
can leave the external archive cluttering up your Arch install if
you're using the Arch backend. See the __del__ documentation
http://python.active-venture.com/ref/customization.html#l2h-175
for details.
Also fixed some out-of-date method names in libbe.diff
|
| |
|
|
|
| |
Presumably the cleanup process removed shutil before cleaning up the Dir.
Now Dir keeps a local reference.
|
| |
|
|
|
|
|
|
| |
I figured out why Arch was complaining. For non-Arch users, file
system access has been tweaked a bit see the BugDir doc string for
details. Also, you should now set BugDir.rcs instead of .rcs_name.
.rcs_name automatically tracks changes in .rcs (the reverse of the
previous situation), so read from whichever you like.
|
| |
|
|
| |
I'd forgotten tell bzr...
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I pushed a lot of the little helper functions into the main classes,
which makes it easier for me to keep track of what's going on. I'm
now at the point where I can run through `python test.py` with each of
the backends (by changing the search order in rcs.py
_get_matching_rcs) without any unexpected errors for each backend
(except Arch). I can also run `test_usage.sh` without non-Arch errors
either.
However, don't consider this a stable commit yet. The bzr backend is
*really*slow*, and the other's aren't blazingly fast either. I think
I'm rewriting the entire database every time I save it :p. Still, it
passes the checks. and I don't like it when zounds of changes build up.
|
| | |
|
| | |
|
| |
|
|
|
| |
Also removed explicit comparisons from beweb/controllers.py, since
they are now built into the Bug.__cmp__ method.
|
| |
|
|
|
|
| |
Not needed with stronger test.py. It's only use would be testing an
installed libbe in place... Maybe that is useful enough? If so, we
can bring it back.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Lots of changes and just one commit. This started with bug
dac91856-cb6a-4f69-8c03-38ff0b29aab2, when I noticed that new bugs
were not being added appropriately with the Git backend. I'd been
working with Git trouble before with bug
0cad2ac6-76ef-4a88-abdf-b2e02de76f5c, and decided things would be
better off if I just scrapped the current RCS architecture and went to
a more object oriented setup. So I did. It's not clear how to add
support for an RCS backend:
* Create a new module that
- defines an inheritor of rsc.RCS, overriding the _rcs_*() methods
- provide a new() function for instantizating the new class
- defines an inheritor of rcs.RCStestCase, overiding the Class attribute
- defines 'suite' a unittest.TestSuite testing the module
* Add your new module to the rest in rcs._get_matching_rcs()
* Add your new module to the rest in libbe/tests.py
Although I'm not sure libbe/tests.py is still usefull.
The new framework clears out a bunch of hackery that used to be
involved with supporting becommands/diff.py. There's still room for
progress though. While implementing the new verision, I moved the
testing framework over from doctest to a doctest/unittest combination.
Longer tests that don't demonstrate a function's usage should be moved
to unittests at the end of the module, since unittest has better
support for setup/teardown, etc.
The new framework also revealed some underimplented backends, most
notably arch. These backends have now been fixed.
I also tweaked the test_usage.sh script to run through all the backends
if it is called with no arguments.
The fix for the dac bug turned out to be an unflushed file write :p.
|
| |
|
|
|
| |
Also added git mode to test_usage.sh.
I'll go through and add modes for the other RCSs...
|
| |\ |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Hubert Chathi's fix was confusing for me, so I made a simpler change.
Seems to work so far. The problem was that
os.path.dirname('filename')
returns an empty string ('') if there are no directories in the
filename. So when `git rev-parse --git-dir` returned '.git', os
returned ''. Later programs didn't recognize '' as a valid directory
and crashed. My fix returns '.' in this case, so we don't crash,
and avoid having to use full paths. I'm not sure why I don't want
to use full paths; they just give me bad vibes...
|
| | |
| |
| |
| | |
Opened, fixed, and closed as bug 31c.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
From the subprocess module documentation:
http://www.python.org/doc/2.5.2/lib/node530.html
"The most common exception raised is OSError. This occurs, for example,
when trying to execute a non-existent file. Applications should prepare
for OSError exceptions."
And from the os module documentation:
http://www.python.org/doc/2.5.2/lib/module-os.html
"exception error
This exception is raised when a function returns a system-related
error (not for illegal argument types or other incidental
errors). This is also known as the built-in exception OSError. The
accompanying value is a pair containing the numeric error code
from errno and the corresponding string, as would be printed by
the C function perror(). See the module errno, which contains
names for the error codes defined by the underlying operating
system.
When exceptions are classes, this exception carries two
attributes, errno and strerror. The first holds the value of the C
errno variable, and the latter holds the corresponding error
message from strerror(). For exceptions that involve a file system
path (such as chdir() or unlink()), the exception instance will
contain a third attribute, filename, which is the file name passed
to the function."
I turned this up running be/test.py, when it defaulted to the tla client
which I didn't have installed. I don't have things working yet, so I
can't create a bug at the moment...
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Using the __desc__ reduces documentation duplication. It's also better
than using __doc__, because __doc__ could (should?) be more than one-line
long, and we just want a short description to jog our memories in the
complete command list.
Also moved unique_name from cmdutil.py to names.py to avoid the
bug->cmdutil->bugdir->bug
cyclic include.
|
| | | |
|
| | |
| |
| |
| | |
This seems like a natual place for a function that only operates on Bugs.
|
| | |
| |
| |
| |
| | |
This file is not used anywhere, and appears to be an outdated version
of libbe/diff.py.
|
| | | |
|
| | |
| |
| |
| |
| | |
Bug keeps timestamps in Bug.time, so working towards consitency for
Comment.
|
| | |
| |
| |
| | |
They don't seem to be used anywhere...
|
| | |
| |
| |
| |
| |
| | |
Also added 'disabled' status back in so diff doesn't choke trying to
load the older versions... Ugly hack, but I don't want to change the
past ;).
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Comment should probably have it's own file too...
I also tried to clean up the interface for setting status and
severity. Both attributes involve selecting strings from predefined
lists. The lists of valid strings (and descriptions of each string)
are now defined in bug.py. The bug.py lists are then used to generate
appropriate help strings in becommands/status.py and severity.py.
This should make it easier to keep the help strings in synch with the
validation information.
The original status strings weren't documented, and I didn't know what
they all ment, so I elimanted some of them. 'in-progress' and
'disabled' are no longer with us. Of course, it would be simple to
add them back in if people don't agree with me on that. Due to the
loss of 'disabled' I had to change the status of two bugs (11e and
597) to 'closed'. I removed becommands/inprogress.py as well. It's
functionality was replaced by the more general status.py command,
which mimics the severity.py command.
|
| | |
| |
| |
| |
| |
| | |
See
http://www.python.org/doc/2.5.2/lib/built-in-funcs.html#l2h-33
http://www.python.org/doc/2.5.2/lib/built-in-funcs.html#l2h-66
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| | |
Now the first bug will have a 3 char short name (used to be one char,
with the second bug having a 3 char name).
|
| |/
|
|
|
| |
* catch Popen() calls to missing VCS binaries
* test.py should only test installed backends
|
| | |
|
| | |
|
| | |
|
| |\ |
|
| | | |
|
| | | |
|
| | | |
|
| | |\ |
|
| | | |
| | |
| | |
| | | |
module and adapt it to win32
|
| | | | |
|
