| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Not just '\n'. Mark Mikofski reported an error on the upgrade from
1.4 to 1.5 on MS Windows:
> upgrading bugdir from "Bugs Everywhere Directory v1.4" to "Bugs Everywhere Directory v1.5"
> Traceback (most recent call last):
> ...
> File "c:\...\libbe\storage\util\upgrade.py", line 141, in check_initial_version
> assert version == self.initial_version, '%s: %s' % (path, version)
> AssertionError: c:\...\.be\version: Bugs Everywhere Directory v1.4
>
> **notes:** I set a breakpoint and it does seem that they are not the same
> (Pdb) self.initial_version
> 'Bugs Everywhere Directory v1.4'
> (Pdb) version
> u'Bugs Everywhere Directory v1.4\r'
We don't need to convert to Unicode, because on Python 2.7:
$ python2.7 -c "print('a' == u'a')"
True
Strange, but true ;). One day we'll migrate BE to Python 3...
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a bug introduced by:
commit 4db1a045a0606bead191a563abc54dfa8352efe0
Author: W. Trevor King <wking@tremily.us>
Date: Wed Aug 29 23:26:17 2012 -0400
Rewrite commands to use bugdirs instead of a single bugdir.
Reported-by: James Spencer <james.s.spencer@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
* Import libraries with an underscore prefix to avoid polluting the
module's public namespace.
* Use a copy `env` to avoid messing with the child process'
environment.
* Pass the tweaked environment on to the PAGER (e.g. for PATH).
* Handle PAGER='' (by not paging).
* Use shlex.split to handle cases like PAGER='less -FRSX' (thanks to
Da_Blitz from pocketnix.org for the bug report and shlex idea).
|
|
|
|
|
|
|
|
|
|
| |
Nathan's post is released under CC BY-SA 3.0 Unported. According the
the FSF, the CC BY-SA 2.0 Generic was not compatible with BE's GPLv2+
[1]. I expect my Python implementation is sufficiently different from
Nathan's original notes to be classified as "fair use" and not an
"adaptation".
[1]: http://www.gnu.org/licenses/license-list.html#ccbysa
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
This brings BEExceptionApp into closer agreement with
libbe.ui.command_line.dispatch(), and avoids having the server go down
when a user submits a silly command.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows you to manage BE servers from inetd scripts, etc.
Shortcomings of the current implementation:
* ServerCommand._daemonize() currently only sets a SIGTERM handler and
double forks. If you want to do this right, see PEP 3143.
Unfortunately, the PEP seems to have stalled, python-daemon appears
unmaintained, and I don't care enough at the moment to do this
right.
* ServerCommand._get_pidfile() races between checking for an existing
PID file and claiming the file itself. It is possible that two
processes would check around the same time, and both see no existing
file. Then they would both open the PID file and write their pid,
without noticing that the other process was contending for the file.
Solving this requires file locking, which is difficult to do
portably. This shouldn't be an issue in normal operation, where
each server will be using its own PID file path.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This was broken in the creation of libbe.util.wsgi from
libbe.command.serve:
commit 0fa17f6bf6a809df14ae1930542059a9e62066b0
Author: W. Trevor King <wking@tremily.us>
Date: Mon Aug 27 13:37:58 2012 -0400
libbe:util:wsgi: extract WSGI utilities into a separate module.
|
|
|
|
|
|
|
|
|
|
|
| |
This was lost in the creation of libbe.util.wsgi from
libbe.command.serve:
commit 0fa17f6bf6a809df14ae1930542059a9e62066b0
Author: W. Trevor King <wking@tremily.us>
Date: Mon Aug 27 13:37:58 2012 -0400
libbe:util:wsgi: extract WSGI utilities into a separate module.
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the "Bugs Everywhere Tree 1 0" -> "Bugs Everywhere
Directory v1.1" upgrade broken by the switch to JSON in:
commit a95915c6c7d6a4e29c1e5547580e0c1fed2467e1
Author: W. Trevor King <wking@tremily.us>
Date: Mon Sep 17 08:14:21 2012 -0400
storage:util:mapfile: convert YAML settings to JSON.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
My Repository.revparse_single() series was merged into pygit2 with:
Merge: 3e9daa4 0238fb7
Author: J. David Ibáñez <jdavid.ibp@gmail.com>
Date: Tue Sep 25 15:10:55 2012 +0200
Merge remote-tracking branch 'wking/revparse'
But this happened after the 0.17.3 release. The next pygit2 release
should contain the .revparse_single() code.
The getattr() hackery works because versions of pygit2 before 0.17.3
lacked a __version__ attribute.
|
| |
|
| |
|
|
|
|
|
|
| |
Importing `yaml` may fail (if the user doesn't have PyYAML installed),
but don't die until we need to use it. This way users without the old
YAML formats on disk can run BE without installing PyYAML.
|
| |
|
| |
|
| |
|
|
|
|
|
| |
This happens because SimpleBugDir is not defined if libbe.TESTING is
not set before importing libbe.bugdir.
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
| |
Add a documentation section discussing the config file, respect
XDG_CONFIG_HOME, and add BE_CONFIG_PATH.
|
|
|
|
|
|
| |
Only official releases get a version number, which should help avoid
confusion. If you're running a live checkout, you shouldn't be scared
off by SHAs.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should have been done back in:
commit a95915c6c7d6a4e29c1e5547580e0c1fed2467e1
Author: W. Trevor King <wking@tremily.us>
Date: Mon Sep 17 08:14:21 2012 -0400
storage:util:mapfile: convert YAML settings to JSON.
I also add an empty-settings generation as a sanity check.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Now that my pull request has been accepted, we can be fairly confident
that future releases of pygit2 will expose this attribute. The
accepted patch was a bit different from the original submission:
Add 'pygit2.__version__' for easy access from client software.
https://github.com/libgit2/pygit2/pull/128
commit f10d2b7b3f0c67d81b175326035e4813420156bd
|
|
|
|
|
|
| |
border-radius and friends are standard CSS3 [1].
[1]: http://www.w3.org/TR/css3-background/#the-border-radius
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These were introduced in
commit d61d54ce33022f0613c5e19e2f52be4ab77c4664
Author: Gianluca Montecchi <gian@grys.it>
Date: Mon Jan 24 22:47:32 2011 +0100
New html output for html command
and propogated in
commit 5b6be7a511670cdf1961d13040cddcb34e70b8a1
Author: W. Trevor King <wking@drexel.edu>
Date: Sun Apr 17 02:41:07 2011 -0400
Rework `be html` to use Jinja2 templates.
|
|
|
|
|
|
|
|
|
| |
This is faster and still readable. I also add an upgrader to convert
bug directories from:
Bugs Everywhere Directory v1.4
to:
Bugs Everywhere Directory v1.5
but I haven't upgraded the local bugdir yet.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If `pygit2` is installed, use it (via PygitGit) rather than calling
the stand-alone `git` executable for all the Git (via ExecGit) for all
the Git storage stuff. This saves one serializing/deserializing and
process setup/teardown. I timed each test suite by commenting out one
of the `make_vcs_testcase_subclasses()` calls at the end of `git.py`
and running
$ time python test.py libbe.storage.vcs.git
The ExecGit tests ran in 13.7s and the PygitGit tests ran in 3.6s for
a 3.8x speedup.
I had to stretch pygit2 a bit to get a clean fit, so if you want to
test this, you'll need to build pygit2 with the following merge
requests:
Add 'pygit2.__version__' for easy access from client software.
https://github.com/libgit2/pygit2/pull/128
commit 0238fb72dfdf2a2308f2da347717cbaafddc4b83
signature: Add keyword argument parsing to Signature().
https://github.com/libgit2/pygit2/pull/129
commit c934858b629f40221406f34166dd77e881b9d5fd
repository: add Repository.revparse_single()
https://github.com/libgit2/pygit2/pull/131
commit 3afdc8b2f59ed137531671fedde36f3a39cbcc9d
|
|
|
|
|
| |
VCS_get_user_id_TestCase.test_gets_existing_user_id is now
VCS_get_user_id_TestCase.test_get_existing_user_id
|
| |
|
| |
|
| |
|
| |
|