aboutsummaryrefslogtreecommitdiffstats
path: root/libbe
Commit message (Collapse)AuthorAgeFilesLines
* I changed my mind and fixed #/03d07e61#.W. Trevor King2012-02-251-1/+9
|
* Keep stdin (file descriptor 0) open in the pager's child process.W. Trevor King2012-02-251-1/+0
| | | | | | | | | This fixes the underlying problem that we worked around in commit 2c9ae15f53aef57d28091b237c193c653c6e80dd. Now even $ echo 'some bug | be --paginate new - will work instead of raising IOError: [Errno 9] Bad file descriptor.
* Add `new` to list of commands that should not default to using the pager.W. Trevor King2012-02-251-1/+1
| | | | | | | | | | | | | | | | | | If the command is run in the pager, access to stdin is tricky, so I avoid it by default. I'd just missed the fact that `new -` used stdin, which caused https://bugzilla.redhat.com/show_bug.cgi?id=751473 $ be new - Traceback (most recent call last): ... File "/usr/lib/python2.7/site-packages/libbe/command/new.py", line 89, in _run summary = self.stdin.readline() ... File "/usr/lib64/python2.7/codecs.py", line 473, in read newdata = self.stream.read(size) IOError: [Errno 9] Bad file descriptor
* Hide the traceback on InvalidURL errors.W. Trevor King2012-02-251-0/+5
| | | | | | | | | In response to https://bugzilla.redhat.com/show_bug.cgi?id=733945 in which Neal Becker was bummed at the long traceback, which may initially look like a programming issue.
* Remove util.subproc.Pipe, as we no longer use it in BE.W. Trevor King2012-02-251-139/+0
| | | | | | | | | | This was at one point used by `update_copyright.py`. Now that that is an external package (and doesn't use `Pipe` anymore either), we can safely remove this code. As a side benifit, the Pipe doctests will no longer be there to fail on OS X and other systems sufficiently different from my development box.
* Avoid generating another StringIO instance in StringInputOutput.get_stdout().W. Trevor King2012-02-241-2/+1
|
* Add update-copyright as a submodule and update release.py accordingly.W. Trevor King2012-02-161-3/+3
| | | | Also add `**kwargs` to `invoke` so we can specify the environment.
* Ran update-copyright.py.W. Trevor King2012-02-1661-610/+610
|
* Fix my busted 1512c0e2a64e patch to libbe/util/encoding.py.W. Trevor King2011-11-135-9/+9
| | | | | | | | | | | | | | Some temporary changes to encoding.py seem to have been added to commit 1512c0e2a64e19c8d4e5697257a4df5ddd8bc727 Author: W. Trevor King <wking@drexel.edu> Date: Tue Nov 8 07:14:43 2011 -0500 by accident. The initial change came from discussions with Niall Douglas, during which I realized that "filesystem encoding" ususally means the encoding for the *path*, not the *contents*. To avoid further confusion I'd renamed `get_filesystem_encoding` to the less ambiguous `get_text_file_encoding`. This commit should complete the transition.
* Ran update_copyright.py.W. Trevor King2011-11-093-0/+3
|
* Correct doc/install.txt to refer to INSTALL_OPTIONS instead of PREFIX.W. Trevor King2011-11-081-6/+2
| | | | | | | This catches the docs up with the changes made in: commit a7ad89a6ad7da55089e6f9a4cdd645b7079ee04e Author: W. Trevor King <wking@drexel.edu> Date: Sat Apr 16 21:26:02 2011 -0400
* Add the BE_ENCODING environmental variable to override the default encoding.W. Trevor King2011-09-081-1/+3
|
* Adjust encoding detection (using sys.getfilesystemencoding for file contents).W. Trevor King2011-09-081-5/+8
|
* Fixed #/bc1e6ff4# (extra argument crash).W. Trevor King2011-09-071-2/+3
|
* Oops, that forgot the equals part of Mercurial 1.9 or greater.W. Trevor King2011-09-071-1/+1
|
* Adjust Mercurial execution so it works with version 1.9 and earlier.W. Trevor King2011-09-071-3/+9
| | | | | | | This makes the changes for 1.9 brought in by bb645f8e489b9f50cd0aec7237ec9adb721797a8 optional. If the Mercurial version is 1.9 or greater, the new code is used. Otherwise, the old code is used.
* Move Bzr.version_cmp to VCS.version_cmp.W. Trevor King2011-09-072-92/+91
| | | | The version comparison code will be useful for all VCSs.
* Merge remote branch 'pschumms/master'W. Trevor King2011-09-071-6/+4
|\
| * Minor fix to doctest for command.base.get_command(); failure introduced by ↵Phil Schumm2011-07-301-0/+1
| | | | | | | | change to command.base.UnknownCommand in commit 0d5c9c68e947617c9d073d5f19351bdd8f3866db
| * Fixed problem with Hg support under version 1.9 ↵Phil Schumm2011-07-281-6/+4
| | | | | | | | (mercurial.dispatch.dispatch() now takes a single request object with option for capturing output stream)
* | Remove redundant re import from previous bzr version_cmp patch.W. Trevor King2011-09-071-1/+0
| |
* | Enhance Bzr.version_cmp to handle non-numeric versionsMichel Alexandre Salim2011-09-071-9/+50
| | | | | | | | | | | | | | | | | | | | | | | | bzr uses non-numeric tags to indicate prereleases; previously, this triggers an exception in be's Bzr module as version comparison is only supported between version strings that only contain numbers and dots. This patch extends version_cmp to support a single non-numeric pre-release string of arbitrary length (e.g. 'a', 'b', 'pre', 'rc'), and extends the docstring tests to cover this extension. Signed-off-by: Michel Alexandre Salim <salimma@fedoraproject.org>
* | Add ImportError to UnknownCommand output in get_command doctest.W. Trevor King2011-07-301-0/+1
| | | | | | | | | | | | | | | | | | | | This catches the test result up after: Commit: 0d5c9c68e947617c9d073d5f19351bdd8f3866db Author: W. Trevor King <wking@drexel.edu> Date: Wed May 25 10:30:19 2011 -0400 Attach ImportError message to UnknownCommand to aid debugging.
* | bugseverywhere.org has changed URL handling, so use different URLs for HTTP ↵W. Trevor King2011-07-301-3/+3
|/ | | | testing.
* Raise UserError if summary is not given to `be commit`.W. Trevor King2011-05-251-0/+3
| | | | | | | | | If the user doesn't provide the summary on the command line, through stdin, or through editor_string, raise an error. This will generally happen with $ be commit (user doesn't enter any text in the editory)
* Attach ImportError message to UnknownCommand to aid debugging.W. Trevor King2011-05-251-3/+8
|
* Rework summary handling in `be commit`.W. Trevor King2011-05-251-6/+18
| | | | | | Now you can run `be commit` with no options and have the summary split off the body automatically. This should be more familiar to most VCS users.
* Run update_copyright.py.W. Trevor King2011-05-2558-35/+104
|
* Move Tim Guirgies' help for status/severity overrides to .W. Trevor King2011-05-253-35/+54
|
* Remove "be set" reference in favour of actual helpTim Guirgies2011-05-252-2/+32
| | | | | | | | Because "be set severity blah" does not actually work, referring users there to set custom severity levels is just cruel (I spent a half hour trying to figure out what I was doing wrong). Thus, it is much easier to, at least for now, state in the help message what they must do in order to get custom severities and statuses.
* Teach be status --help to load per tree configTim Guirgies2011-05-251-0/+4
| | | | | | Again, there is discrepancy between severity.py and status.py. I thought this feature was extremely useful in severity.py and it should be put into status.py too.
* Restructure severity help function to match statusTim Guirgies2011-05-251-11/+16
| | | | | | | | | | | | | | | The code structure was vastly different in severity.py to status.py, so I mostly copied the structure from there and adjusted it to suit severity. The structure in status.py looked (to me) cleaner, more organised, and easier to work with. Also, users are now referred by "be severity --help" to "be set --help", in a manner similar to "be status --help". For those that don't know that severity can be adjusted on a per repository basis, this seems extremely helpful. A similar message appears for status, but not here.
* Use open() instead of file() in CachedPathID doctests (2to3 compatability).W. Trevor King2011-05-121-3/+3
|
* Remove form feeds (for compatibility with 2to3).W. Trevor King2011-05-127-7/+7
|
* Convert tabs to spaces in a libbe.bug indention.W. Trevor King2011-05-121-1/+1
|
* Update libbe.util.id other_uuids documentation (may contain uuid).W. Trevor King2011-05-121-4/+4
|
* Make BugDir._uuids_cache a set.W. Trevor King2011-05-121-9/+13
| | | | | | | | | | | | For `be list` on a bugdir with 4096 open bugs, this reduced the cumulative time spend in 8194 calls to BugDir.uuids() from 41 seconds to 33 seconds. Of the 33 cumulative seconds, 24 were spend in uuids() itself (and not in child functions), which is probably from the list comprehension extracting in-memory Bug uuids. With fancier accounting, you could probably trust _uuids_cache to already contain all the in-memory uuids and dispense with the union altogether.
* Cache Bug.time by hand to avoid lots of redundant calls to str_to_time.W. Trevor King2011-05-121-2/+11
|
* Fix test_log_request (broken by commit 36699d82).W. Trevor King2011-05-111-1/+1
|
* Add extra strings to Bug.string() output.W. Trevor King2011-05-021-0/+2
|
* Revive the UserError/UsageError distinctionW. Trevor King2011-05-023-13/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | UsageError was removed back in commit bf3d434b244c57556bec979acbc658c30eb58221 Author: W. Trevor King <wking@drexel.edu> Date: Sat Dec 12 00:31:55 2009 -0500 Added libbe.command.base (with Command class)... because the distinction between UsageError and UserError was unclear. I've brought it back to satisfy a request by Christian Heinrich: On Sun, May 01, 2011 at 02:52:13AM +0200, Christian Heinrich wrote: > 3.) Using wrong syntax should receive better help messages. > > Current: > > "be new" -> ERROR: > Missing required argument SUMMARY > > Should be: > > "be new" -> usage: be new [options] SUMMARY > ... He suggested we print the full option list as well, but I've decided to just print the usage summary and remind the user how to get the full help message if they want it.
* Add summary line to the Serve command.W. Trevor King2011-05-011-1/+6
| | | | Thanks to Christian Heinrich for pointing this out.
* "X or ''|e" -> "(X or '')|e" for proper escaping.W. Trevor King2011-04-171-7/+7
|
* Correct <tdata> -> <tbody> typo in `be html` templates.W. Trevor King2011-04-171-2/+2
|
* Ensure comment div ids start with a letter (per validator.w3.org).W. Trevor King2011-04-171-2/+2
|
* Correct <tbody> -> </tbody> typo in `be html` templates.W. Trevor King2011-04-171-1/+1
|
* Rework `be html` to use Jinja2 templates.W. Trevor King2011-04-171-558/+530
|
* Revert 54801289, which makes it impossible to save new bugs/comments.W. Trevor King2011-04-162-2/+4
|
* Remove old exception types from libbe.bug and libbe.comment.W. Trevor King2011-04-162-17/+0
|
* Raise exceptions if bug or comment value files are missing.W. Trevor King2011-04-162-4/+2
| | | | | | | | | This happens most often when a previous crash leaves an empty directory `abc` in .be/.../bugs/abc/ or .be/.../bugs/.../comments/abc/. The new exception ensures the error message is "Bug/Comment X missing value file" which tells you where to look for the repository corruption not "summary is None" which told you nothing.