| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Versioned properties whose data is a mutable type are tricky, since
the simple comparisons we'd been using in
libbe.properties.change_hook_property don't work for mutables. For
now, we avoid that problem by assuming a change happened whenever a
mutable property is set. change_hook_property is a bit untidy at the
moment while I work out how to deal with mutables.
As an example of using Bug.extra_strings to patch on some useful
functionality, I've written becommands/tag.py. I'd suggest future
add-ons (e.g. becommands/depend.py?) use the "<LABEL>:<value>" string
format to keep it easy to sort out which strings belong to which
add-ons. tag.py is still missing command line tag-removal and
tag-searching for `be list'. Perhaps something like
be list --extra-strings TAG:<your-tag>,TAG:<another-tag>,DEPEND:<bug-id>
would be good, although it would requre escaping commas from the tags,
or refusing to allow commas in the tags...
libbe.properties.ValueCheckError also got a minor update so the
printed error message makes sense when raised with allowed being an
iterable (i.e. check_property) or a function
(e.g. fn_checked_property).
All of this digging around turned up a really buggy
libbe.bugdir.MultipleBugMatches. Obviously I had never actually
called it before :p. Should be fixed now.
libbe.comment._set_comment_body has also been normalized to match the
suggested change_hook interface: change_hook(self, old, new).
Although, I'm not sure why it hadn't been causing obvious problems
before, so maybe I'm misunderstanding something about that.
|
| | |
|
| |
|
|
|
|
| |
Since
<creator>John Doe <jdoe@example.com></creator>
is not valid XML.
|
| |
|
|
| |
The xml() method hadn't been updated since the settings_object revamp.
|
| |
|
|
|
| |
Renamed "name" -> "short-name" and "in_reply_to" -> "in-reply-to".
Reordered uuid before short-name.
|
| |\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I rewrote a few of his routines, e.g. generalizing
Comment.string_thread to run a caller-specified method avoided the
need for some duplicate code in Comment.xml_thread. There was also a
reasonable reorganization of libbe.settings_object.versioned_property
because the <in_reply_to> field of the Comment.xml output was giving
me `-1' (= old settings_object.EMPTY) instead of None, even after I
had set comm.in_reply_to to None. The rewritten versioned_property
avoids the ambiguity of UNPRIMED vs EMPTY, and avoids the stupididy of
my using EMPTY=-1 ;).
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
If bug_A had no comments (and so, no comment directory), changing
comment settings before saving raised missing directory errors.
save_settings had previously assumed the
.be/bugs/XYZ/comments/
directory existed, which wasn't true for comment-less bugs. Now it
checks, and creates the directory if necessary.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
settings_object.SavedSettingsObject encapsulates some of the common
settings functionality in the BE BugDir, Bug, and Comment classes.
It's a bit awkward due to the nature of scoping in python subclasses,
but it's better than reproducing this code in each of the above classes.
Now I need to move Bug and Comment over to *this* system ;).
|
| | |
| |
| |
| |
| | |
Also some typo corrections and some reworking of bug/bugdir to better
support the lazier loading.
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
I borrowed most of the code for this.
get_encoding() is from Trac
http://trac.edgewall.org/browser/trunk/trac/util/datefmt.py
format_datetime()
Trac has a BSD license
http://trac.edgewall.org/wiki/TracLicense
I don't know if such a small snippet requires us to "reproduce the
above copyright" or where we need to reproduce it if it is needed.
The stdout/stdin replacement code follows
http://wiki.python.org/moin/ShellRedirectionFails
Because of the stdout replacement, the doctests executes now need an
optional 'test' argument to turn off replacement during the doctests,
otherwise doctest flips out (since it had set up stdout to catch
output, and then we clobbered it's setup).
References:
http://wiki.python.org/moin/Unicode
http://www.amk.ca/python/howto/unicode
http://www.python.org/dev/peps/pep-0100/
I also split libbe/editor.py off from libbe.utility.py and started
explaining the motivation for the BugDir init flags in it's docstring.
|
| |/ |
|
| |
|
|
|
| |
Also emptied becommands/__init__.py. I didn't understand the plugin
interface when I wrote it.
|
| |
|
|
|
|
|
|
|
|
| |
It makes tracebacks almost illegible. I doubt markup/markdown systax
or auto-formatting is really useful, since bugs-reports are ususally a
short comment and a traceback.
I also closed a4d38ba7-ec28-4096-a4f3-eb8c9790ffb2 and
7bfc591e-584a-476e-8e11-b548f1afcaa6, which have probably been fixed
for a long time...
|
| |
|
|
|
| |
Now mapfile access has fewer special cases, and there is less
redundant rcs.add/update code.
|
| |
|
|
| |
Fixes bug b3c6da51-3a30-42c9-8c75-587c7a1705c5
|
| |
|
|
| |
Also some minor cleanups.
|
|
|
I'd forgotten tell bzr...
|
