aboutsummaryrefslogtreecommitdiffstats
path: root/libbe/bugdir.py
Commit message (Collapse)AuthorAgeFilesLines
* Added Bug.extra_strings to support add-on functionality, e.g. `be tag`.W. Trevor King2009-06-231-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Versioned properties whose data is a mutable type are tricky, since the simple comparisons we'd been using in libbe.properties.change_hook_property don't work for mutables. For now, we avoid that problem by assuming a change happened whenever a mutable property is set. change_hook_property is a bit untidy at the moment while I work out how to deal with mutables. As an example of using Bug.extra_strings to patch on some useful functionality, I've written becommands/tag.py. I'd suggest future add-ons (e.g. becommands/depend.py?) use the "<LABEL>:<value>" string format to keep it easy to sort out which strings belong to which add-ons. tag.py is still missing command line tag-removal and tag-searching for `be list'. Perhaps something like be list --extra-strings TAG:<your-tag>,TAG:<another-tag>,DEPEND:<bug-id> would be good, although it would requre escaping commas from the tags, or refusing to allow commas in the tags... libbe.properties.ValueCheckError also got a minor update so the printed error message makes sense when raised with allowed being an iterable (i.e. check_property) or a function (e.g. fn_checked_property). All of this digging around turned up a really buggy libbe.bugdir.MultipleBugMatches. Obviously I had never actually called it before :p. Should be fixed now. libbe.comment._set_comment_body has also been normalized to match the suggested change_hook interface: change_hook(self, old, new). Although, I'm not sure why it hadn't been causing obvious problems before, so maybe I'm misunderstanding something about that.
* Added `be list --sort *` for user-selectable sorting.W. Trevor King2009-06-221-7/+0
| | | | | | | | | | | Also added libbe.bug.cmp_last_modified, which handles part of 9ce2f015-8ea0-43a5-a03d-fc36f6d202fe. To do better we could extend the RCS framework. I also transcribed a few emails from the be-devel list onto their relavent bugs and closed a few bugs. Finally, I removed some left over InvalidValue cruft.
* Fixed lack of user_id caching in bugdir.BugDirW. Trevor King2008-12-041-5/+9
|
* Added per-tree default assignee option.W. Trevor King2008-12-041-1/+6
| | | | | The new setting is currently only used when creating new bugs with becommand/new.
* Per-tree status levels working.W. Trevor King2008-12-041-1/+23
|
* Per-tree settings now passed into bug module.W. Trevor King2008-12-041-1/+9
| | | | | | | | becommands/severity gets the configured settings appropriately. Todo: adjust setting-validation to compare against the current values. setup becommands/severity to --complete severities.
* Added per-tree configurable severities.W. Trevor King2008-12-041-0/+4
| | | | | | | They currently have no effect, but you can see them with $ be set There's a lot of information in this one 'settings' variable. I think set will have to be specialized to handle arrays smoothly...
* Added decorator-style properties to bugdir. Created settings_object module.W. Trevor King2008-12-021-137/+121
| | | | | | | | settings_object.SavedSettingsObject encapsulates some of the common settings functionality in the BE BugDir, Bug, and Comment classes. It's a bit awkward due to the nature of scoping in python subclasses, but it's better than reproducing this code in each of the above classes. Now I need to move Bug and Comment over to *this* system ;).
* Added decorator-style properties to libbe/comment.py.W. Trevor King2008-12-011-0/+32
| | | | | Also some typo corrections and some reworking of bug/bugdir to better support the lazier loading.
* Added libbe/encoding.py to wrap input/output/file access appropriately.W. Trevor King2008-11-251-27/+96
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | I borrowed most of the code for this. get_encoding() is from Trac http://trac.edgewall.org/browser/trunk/trac/util/datefmt.py format_datetime() Trac has a BSD license http://trac.edgewall.org/wiki/TracLicense I don't know if such a small snippet requires us to "reproduce the above copyright" or where we need to reproduce it if it is needed. The stdout/stdin replacement code follows http://wiki.python.org/moin/ShellRedirectionFails Because of the stdout replacement, the doctests executes now need an optional 'test' argument to turn off replacement during the doctests, otherwise doctest flips out (since it had set up stdout to catch output, and then we clobbered it's setup). References: http://wiki.python.org/moin/Unicode http://www.amk.ca/python/howto/unicode http://www.python.org/dev/peps/pep-0100/ I also split libbe/editor.py off from libbe.utility.py and started explaining the motivation for the BugDir init flags in it's docstring.
* Adjusted becommands/set to handle user_id properly.W. Trevor King2008-11-241-7/+10
|
* Added Bug.comments(), BugDir.has_bug() & cleaned up diff.diff().W. Trevor King2008-11-241-14/+19
| | | | + some other minor fixes and cleanups.
* Replaced direct filesystem read from bugdir.py with RCS mediated read.W. Trevor King2008-11-241-6/+9
| | | | | | | | | Also replaced utility.FileString with StringIO() in cmdutil.py, which allowed the removal of utility.FileString and utility.get_file. The only remaining file().read() outside the RCS framework is the read in utility.editor_string(), but should probably not go through the RCS.
* Added 'allow_no_rcs' flag to RCS file system access methods.W. Trevor King2008-11-241-50/+82
| | | | | Now mapfile access has fewer special cases, and there is less redundant rcs.add/update code.
* Created bugdir.MultipleBugMatches so bugdir no longer imports cmdutil.W. Trevor King2008-11-231-3/+9
|
* Removed outdated beuuid import from libbe/bugdir.pyW. Trevor King2008-11-231-1/+0
|
* Go back to lazy bug loading to get execution speed back up.W. Trevor King2008-11-231-17/+25
| | | | Fixes bug b3c6da51-3a30-42c9-8c75-587c7a1705c5
* Improved user-id saving/loading/caching & save user-id into duplicate bugdirs.W. Trevor King2008-11-231-16/+19
| | | | | | Fixes the duplicate bugs a403de79-8f39-41f2-b9ec-15053b175ee2 c894f10f-197d-4b22-9c5b-19f394df40d4
* Added bugdir user-id caching and save/load from settings file.W. Trevor King2008-11-231-0/+31
|
* Explicit rcs.cleanup() in bugdir test.W. Trevor King2008-11-221-3/+3
| | | | | | | | | | | | | Don't use del(rcs), because if there was an error, there is still a reference to rcs in the traceback, so it is never cleaned up. This can leave the external archive cluttering up your Arch install if you're using the Arch backend. See the __del__ documentation http://python.active-venture.com/ref/customization.html#l2h-175 for details. Also fixed some out-of-date method names in libbe.diff
* Created and fixed bug 496edad5-1484-413a-bc68-4b01274a65eb.W. Trevor King2008-11-221-23/+90
| | | | | | | | I figured out why Arch was complaining. For non-Arch users, file system access has been tweaked a bit see the BugDir doc string for details. Also, you should now set BugDir.rcs instead of .rcs_name. .rcs_name automatically tracks changes in .rcs (the reverse of the previous situation), so read from whichever you like.
* Another major rewrite. Now BugDir, Bug, and Comment are more distinct.W. Trevor King2008-11-211-134/+222
| | | | | | | | | | | | | | | I pushed a lot of the little helper functions into the main classes, which makes it easier for me to keep track of what's going on. I'm now at the point where I can run through `python test.py` with each of the backends (by changing the search order in rcs.py _get_matching_rcs) without any unexpected errors for each backend (except Arch). I can also run `test_usage.sh` without non-Arch errors either. However, don't consider this a stable commit yet. The bzr backend is *really*slow*, and the other's aren't blazingly fast either. I think I'm rewriting the entire database every time I save it :p. Still, it passes the checks. and I don't like it when zounds of changes build up.
* Moved bug.new_bug code into bugdir.BugDir.new_bug.W. Trevor King2008-11-191-0/+4
| | | | | Also removed explicit comparisons from beweb/controllers.py, since they are now built into the Bug.__cmp__ method.
* Major rewrite of RCS backends. RCS now represented as a class.W. Trevor King2008-11-181-21/+76
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Lots of changes and just one commit. This started with bug dac91856-cb6a-4f69-8c03-38ff0b29aab2, when I noticed that new bugs were not being added appropriately with the Git backend. I'd been working with Git trouble before with bug 0cad2ac6-76ef-4a88-abdf-b2e02de76f5c, and decided things would be better off if I just scrapped the current RCS architecture and went to a more object oriented setup. So I did. It's not clear how to add support for an RCS backend: * Create a new module that - defines an inheritor of rsc.RCS, overriding the _rcs_*() methods - provide a new() function for instantizating the new class - defines an inheritor of rcs.RCStestCase, overiding the Class attribute - defines 'suite' a unittest.TestSuite testing the module * Add your new module to the rest in rcs._get_matching_rcs() * Add your new module to the rest in libbe/tests.py Although I'm not sure libbe/tests.py is still usefull. The new framework clears out a bunch of hackery that used to be involved with supporting becommands/diff.py. There's still room for progress though. While implementing the new verision, I moved the testing framework over from doctest to a doctest/unittest combination. Longer tests that don't demonstrate a function's usage should be moved to unittests at the end of the module, since unittest has better support for setup/teardown, etc. The new framework also revealed some underimplented backends, most notably arch. These backends have now been fixed. I also tweaked the test_usage.sh script to run through all the backends if it is called with no arguments. The fix for the dac bug turned out to be an unflushed file write :p.
* Moved libbe.cmdutil.bug_summary() to libbe.bug.Bug.string().W. Trevor King2008-11-151-2/+2
| | | | This seems like a natual place for a function that only operates on Bugs.
* Split Bug and Comment class out to bug.py from bugdir.pyW. Trevor King2008-11-141-254/+8
| | | | | | | | | | | | | | | | | | | | | Comment should probably have it's own file too... I also tried to clean up the interface for setting status and severity. Both attributes involve selecting strings from predefined lists. The lists of valid strings (and descriptions of each string) are now defined in bug.py. The bug.py lists are then used to generate appropriate help strings in becommands/status.py and severity.py. This should make it easier to keep the help strings in synch with the validation information. The original status strings weren't documented, and I didn't know what they all ment, so I elimanted some of them. 'in-progress' and 'disabled' are no longer with us. Of course, it would be simple to add them back in if people don't agree with me on that. Due to the loss of 'disabled' I had to change the status of two bugs (11e and 597) to 'closed'. I removed becommands/inprogress.py as well. It's functionality was replaced by the more general status.py command, which mimics the severity.py command.
* Changed __get/setattribute__ calls to get/setattr() calls.W. Trevor King2008-11-141-4/+4
| | | | | | See http://www.python.org/doc/2.5.2/lib/built-in-funcs.html#l2h-33 http://www.python.org/doc/2.5.2/lib/built-in-funcs.html#l2h-66
* Add GIT support, from Chris Ball and Michael Stone.Chris Ball2008-05-161-2/+2
|
* Add support for Mercurial (Steve Borho)Aaron Bentley2007-01-231-1/+1
|
* win32: fix crash of 'be show' when bug don't have commentsAlexander Belchenko2006-07-191-1/+4
|
* Support for content-type in commentsAaron Bentley2006-04-061-1/+3
|
* Removed debugging codeAaron Bentley2006-04-031-1/+0
|
* Added reply handling to commentsAaron Bentley2006-04-031-1/+22
|
* Added a repr for BugAaron Bentley2006-03-311-0/+3
|
* More unicode stuffAaron Bentley2006-01-261-2/+3
|
* Added more possible bug statusesAaron Bentley2006-01-251-2/+4
|
* Various Windows-related bugfixesAaron Bentley2005-12-221-9/+19
|
* Better error when bad path specifiedAaron Bentley2005-12-151-0/+2
|
* Distinguished between 'paranoid' and non-paranoid add-idAaron Bentley2005-05-191-1/+1
| | | | | The paranoid adds are only used for the .be root. Paranoia is a big time-suck on Arch trees, because they require a full inventory.
* Added tests for double-initAaron Bentley2005-05-181-3/+18
|
* Better errors for bad bug rootsAaron Bentley2005-05-181-1/+17
|
* Added appropriate copyright notices, GPLed.Aaron Bentley2005-05-161-0/+16
|
* Support for bzr inventory operationsAaron Bentley2005-05-041-3/+4
|
* Added new status - "in-progress" (Oleg Romanyshyn)Aaron Bentley2005-04-221-2/+2
|\ | | | | | | | | | | | | | | | | Patches applied: * oromanyshyn@panoramicfeedback.com--development2/bugs-everywhere--0--base-0 * tag of aaron.bentley@utoronto.ca--be/bugs-everywhere--devel--0--patch-84 * oromanyshyn@panoramicfeedback.com--development2/bugs-everywhere--0--patch-1 * Added new status - "in-progress"
| * Added new status - "in-progress"Oleg Romanyshyn2005-04-221-2/+2
| |
* | Added preliminary tree-diffing supportAaron Bentley2005-04-141-0/+9
|/
* Implemented tests for 'open'Aaron Bentley2005-03-241-6/+10
|
* Fixed the bug dir path in BugDirs produced by create_bug_dirAaron Bentley2005-03-241-1/+1
|
* Added comment support to show, added comment commandAaron Bentley2005-03-231-1/+1
|
* Implemented commentsAaron Bentley2005-03-231-1/+94
|