aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Added becommands/subscribe.py to manage subscription list.W. Trevor King2009-07-223-0/+250
|
* Merged assorted changes from be.wtk-rr for BugDir.extra_strings.W. Trevor King2009-07-21167-119/+4464
|\ | | | | | | | | | | | | Other highlights: * be show --no-comments * Improved *.sync_with_disk. * Improved be-mbox-to-xml.
| * Added .extra_strings to BugDir and CommentW. Trevor King2009-07-214-10/+50
| |\
| | * I'll add Comment.extra_strings too, while I'm at it.W. Trevor King2009-07-211-0/+14
| | |
| | * Added BugDir.extra_strings.W. Trevor King2009-07-211-0/+14
| | |
| | * Bug._extra_strings_check_fn() guts now utility.iterable_full_of_strings().W. Trevor King2009-07-212-10/+22
| | |
| * | Merged libbe.properties unittest fixW. Trevor King2009-07-211-4/+8
| |\|
| | * libbe.properties unittest changes due to "extra change-hook save" fix.W. Trevor King2009-07-211-4/+8
| |/ | | | | | | Missed these earlier.
| * I imported a few threads from the mailing list as wishlist bugs.W. Trevor King2009-07-21144-0/+4180
| | | | | | | | | | | | | | | | | | 12c:uw: Bug aggregation. Multi-repo meta-BE? 529:ow: How should we version BE? 2f0:aw: Static html report generation 22b:aw: Sorting targets chronologically d99:aw: CherryPy interface "Cherry-flavored BE" e08:aw: Interactive email interface
| * Added "--no-comments" to "be show".W. Trevor King2009-07-211-9/+16
| | | | | | | | | | | | | | | | | | Also moved the XML-header line to the top of the argument loop, since there should only be one. We're still missing global tags wrapping the whole thing though... Also set options.XML default to False. It had been defaulting to None, which was breaking the non-XML newline-adding check.
| * be-mbox-to-xml is now better at message-id, in-reply-to, and references.W. Trevor King2009-07-211-3/+26
| | | | | | | | | | | | | | | | | | | | | | | | A previous "len(ret) >= 0" had been stripping the alt-id and in-reply-to from _all_ parts of multipart comments. Now it only strips them from parts after the first. The following parts do not specify and alt-id, and they all are in-reply-to the first part. I also added the KNOWN_IDS list for selecting amongst an array of possible in-reply-to or references ids. This works well enough for now, but would be more robust if we could import a list of previously known ids from BE...
| * "be comment --xml" now saves the comments (again).W. Trevor King2009-07-211-0/+1
| | | | | | | | | | | | | | | | | | They are generated in memory (from_disk defaults to False) 133: new = comment.Comment(bug) With the leaner saving since I started trusting sync_with_disk, they were no longer making it to disk. Easily fixed with an explicit save once you've got them all set up.
| * be-mbox-to-xml handles emails without explicit transfer encodings.W. Trevor King2009-07-211-1/+4
| |
| * Added cProfile notes to README.dev.W. Trevor King2009-07-211-0/+9
| |
| * Fixed extra change-hook save in testChangeHookMutableProperty.W. Trevor King2009-07-212-23/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The actual fix was @@ -339,7 +355,10 @@ fset = funcs.get("fset") name = funcs.get("name", "<unknown>") def _fget(self, new_value=None, from_fset=False): # only used if mutable == True - value = fget(self) + if from_fset == True: + value = new_value # compare new value with cached + else: + value = fget(self) # compare current value with cached if _cmp_cached_mutable_property(self, "change hook property", name, value) != 0: # there has been a change, cache new value old_value = _get_cached_mutable_property(self, "change hook property", name) The reason for the double-save was: >>> print t.settings["List-type"]==EMPTY True (the cached value here is EMPTY) >>> t.list_type = [] (old fget compares cached EMPTY to current EMPTY, no change, so no cache. fset notices change and saves EMPTY->[]) >>> t.list_type.append(5) (now fget notices the change EMPTY->[], caches [], and calls extra save) The new way: >>> print t.settings["List-type"]==EMPTY True (the cached value here is EMPTY) >>> t.list_type = [] (fget compares cached EMPTY to new [] and saves EMPTY->[]) >>> t.list_type.append(5) (fget sees no change ([]->[]), which is correct) In addition to the fix and the related corrections to testChangeHookMutableProperty, I added details about mutables to all relevant docstrings and stripped trailing whitespace from both files.
| * Touched up becommands/diff.py's help message.W. Trevor King2009-07-211-3/+4
| |
| * Cleaned up saving/sync_with_disk.W. Trevor King2009-07-2116-54/+108
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Got rid of a whole bunch of redundant .save() calls when sync_with_disk==True. Fixed up the "File-system access" portion of the BugDir docstring so we can all remember how things are supposed to work ;). Note that some .save() calls are still required. For example in becommands/merge.py, the copied comments have their .bug changed, but that is not a versioned property, so it doesn't trigger an automatic save, and we have to force the .save() by hand. libbe.rcs.RCS.mkdir() is now recursive by default, but you can set check_parents==False if you want it to fail in the case of missing parents. Because of the recursion, we removed the .update() call on preexisting directories, since there will be at least one of these occurrences for every .mkdir(check_parents=True) call, and I don't know of any VCS that actually needs them... Also stripped trailing whitespace from some files...
| * Cleaned up some outdated libbe.settings_object.EMPTY cruft.W. Trevor King2009-07-204-11/+10
| | | | | | | | | | | | | | | | From back before commit wking@drexel.edu-20090619184215-nfx205yaj02sqrqx cleaned up the versioned_property implementation. Also a few style fixes and typos.
* | Added: subscribe/unsubscribe (bug #..., "new bugs", "all", etc.)W. Trevor King2009-07-219-0/+100
| |
* | Use shlex.split() to parse control lines in be-handle-mail.W. Trevor King2009-07-203-16/+14
| | | | | | | | Split arguments following POSIX rather than at all whitespace.
* | Added pseudo-header list to interfaces/email/interactive/README.W. Trevor King2009-07-201-14/+17
| | | | | | | | Also some minor textual cleanups.
* | Added psuedo-header handling to be-handle-mail.W. Trevor King2009-07-202-4/+25
| | | | | | | | | | | | | | | | Many psuedo-headers had been ignored. Now they are all implemented. Getting this working exposed a few bugs in error message generation for Commands with IDs in their argument list. These bugs should now be fixed.
* | Added more VCSs to the delete-commit notes in interfaces/README.W. Trevor King2009-07-201-7/+25
| |
* | Added interfaces/email/interactive/README and be-handle-mail options.W. Trevor King2009-07-202-11/+248
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The README should give enough info to install and use the interface. While I was writing it, I thought that be-handle-mail could use the --be-dir, --tag-base, and --test options. generate_global_tags() helps implement the --tag-base option. I set up a unittest framework since checking is currently a pipe-in-emails-by-hand sort of arrangement, which can be slow ;). Currently only generate_global_tags() is tested. I also restored "show" to ALLOWED_COMMANDS, since it seems to have wandered off ;).
* | be-handle-mail shown to successfully commit partially-failing emails.W. Trevor King2009-07-191-0/+18
| | | | | | | | I've added the test-case that show it.
* | More verbose User/UsageError reporting in be-handle-mailW. Trevor King2009-07-191-2/+4
| |
* | Worked out some kinks in be-handle-mail's autocommit.W. Trevor King2009-07-191-1/+6
| | | | | | | | For example, it's helpful to actually run the autocommit command ;).
* | Fixed typos in be-handle-mail error message generationW. Trevor King2009-07-191-4/+4
| |
* | Adjusted final commit-handling in be-handle-mail.W. Trevor King2009-07-191-8/+9
| | | | | | | | | | | | | | | | Now the final commit will run whether or not the preceding commands raise any exceptions. Note that since we've added the "--allow-empty" to "be commit", we don't need to worry about empty commits after read-only actions.
* | Oops, _now_ I've fixed the multipart generation in be-handle-mailW. Trevor King2009-07-191-3/+3
| |
* | Merged "be commit --allow-empty from be.wtk-rr"W. Trevor King2009-07-199-50/+118
|\|
| * Added --allow-empty to "be commit"W. Trevor King2009-07-199-49/+117
| | | | | | | | | | | | | | Previously many backends would silently add an empty commit. Not very useful. When the new --allow-empty flag and related allow_empty options are false, every versioning backend is guaranteed to raise the EmptyCommit exception in the case of an attempted empty commit.
* | Fixed multipart bug in be-handle-mail.Message.response_email()W. Trevor King2009-07-191-5/+4
| | | | | | | | | | I hadn't attached the mutipart body to the .response_header, which meant that the reply lacked target email addresses, etc.
* | Added --disable-autocommit to be-handle-mail.W. Trevor King2009-07-191-1/+15
| | | | | | | | Also restored repsonse-message logging to help track down bugs.
* | be-handle-mail now commits after every successful email execution.W. Trevor King2009-07-191-7/+13
| | | | | | | | | | | | | | | | | | Caveats: It will produce blank commits after emails that make no changes. Todo: --fail-on-null option to "be commit" It will not commit changes due to emails that are partly successful. Todo: add "be revert"
* | Merged becommands/commit.py addition from be.wtk-rr.W. Trevor King2009-07-194-4/+73
|\|
| * Added becommands/commit.py and minor fixes.W. Trevor King2009-07-194-4/+73
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now we can commit changes from the command line with a unified interface. The interface is much less flexible than using your particular version control system's commit command directly, so this command is mostly intended for user-interfaces and other tools that don't want to be bothered with the extra flexibility. Normalized spacing in rcs.RCS.commit to produce: summary <BLANKLINE> body <TRAILING-ENDLINE> messages regardless of the input string format. Also fixed a "--complete" handline bug in cmdutil, and some minor docstring typos in libbe.rcs and .editor.
* | Added more allowed commands and pseudo-headers to be-handle-mail.W. Trevor King2009-07-191-3/+5
| | | | | | | | The new pseudo-headers are currently ignored.
* | Added interfaces/README with commit-deletion notes.W. Trevor King2009-07-191-0/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | Up to now, my email interface never committed automatically, in order to avoid locking in inappropriate changes. However, with the ability to modify bug status, etc., it could be hard to determine the correct status with a single email's effects removed. In order to make that easier, I'm switching over to a "auto-commit after every user action" model, and I've looked up the incantations for commit deletion for bzr and git (the VCSs I use). These incantations are recorded in interfaces/README. Next up: add auto-commit functionality.
* | be-handle-mail's new DBT-style interface handles the example emails now.W. Trevor King2009-07-193-31/+58
| |
* | Reworked be-handle-mail to be more like the Debian Bug Tracker.W. Trevor King2009-07-1911-102/+192
| | | | | | | | | | Changed all the example emails over to the new format. Now it's time to try them all out and fix all the bugs ;).
* | Generalized _procmailrc to allow several tags: [be-bug...W. Trevor King2009-07-191-1/+1
| | | | | | | | | | | | | | | | | | This is part of a process to make the email interface more like the Debian Bug Tracker's. http://www.debian.org/Bugs/Reporting _procmailrc had been out of date anyway, [be-mail] should have been [be-bug].
* | Added new_with_comment ability to be-handle-mail.W. Trevor King2009-07-182-4/+51
| | | | | | | | | | Waiting for a response so you can get the bug ID for your initial comment is silly. Now you don't have to :)
* | Assorted bugfixes to get reworked be-handle-mail working.W. Trevor King2009-07-182-21/+27
| |
* | Major be-handle-mail rewrite to make things more modular.W. Trevor King2009-07-182-173/+269
| | | | | | | | | | Added Command and Message classes, and use new flexibility in send_pgp_mime.py.
* | Oops, forgot to reset from/to_addr in send_pgp_mime.py unittestsW. Trevor King2009-07-181-2/+2
| |
* | Major send_pgp_mime.py reorganization to better integrate with email.Message.W. Trevor King2009-07-181-119/+111
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now send_pgp_mime.py passes it's unittests again, and it should be easier to use from be-handle-mail :). Renamed Mail -> EncryptedMessageFactory, since its role is to generate message bodies of various types (plain, signed, encrypted, ...) Separated the header processing from Mail, now you need to header_from_text() your header text to create an email.Message which you can use in EncrypedMessageFactory.sign(), .encrypt(), ... Once you've created the body message you want, you can attach it to the header with attach_root(header, root_part) where both header and root_part are email.Message instances. Made EncryptedMessageFactory doctests more robust, through the use of # doctest: +ELLIPSIS, +NORMALIZE_WHITESPACE which removed the need for the .strip*() methods. Also added the configurable from_addr and to_addr, which allows you to run the doctests with successful gpg calls. Just set them to some address from your private keyring, and pass the passphrase for that key in to your test via a file (or gpg-agent...) python send_pgp_mime.py -tP path/to/pasphrase/file
* | Starting to seperate message handling in be-handle-mail.W. Trevor King2009-07-181-25/+37
| | | | | | | | | | The goal being to make handling commands differently easier, rather than just passing off the whole interface to becommands.
* | Normalized whitespace in be-handle-mail and send_pgp_mime.py.W. Trevor King2009-07-182-39/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also removed "commit after every message" from be-handle-mail, because a) not implemented yet b) don't want to commit spam, since we'd have to find a way to remove it later. Suggested future workflow: * "bzr diff" to poll for activity, blank output = no activity. * on activity: 1) look at changes 2) remove whatever 3) commit email-interface repo. 4) merge changes into your private repo * on private repo changes: * if activity in email-interface repo: 1) deal with email activity as above * push your private repo onto the email-interface repo (and update the email repos' working tree, if required)
* | be-handle-mail now handles non-text comments.W. Trevor King2009-07-181-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | This required replacing both the codec-wrapped sys.stdin _and_ the raw sys.__stdin__ with StringIO(stdin). becommands/comment will use only one or the other depending on the comment's content type. Caveat: Get_body_type only grabs the body and type of the first non-mulitpart section, which may not be what the user expects. Todo: Add multiple comments for each part of a multipart message, like we do in interfaces/xml/be-mbox-to-xml.