aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Improved unittest cleanup by adding BugDir.cleanup().W. Trevor King2009-07-3121-56/+93
| | | | | | | | Also simple_bug_dir -> SimpleBugDir class, which allows me to add utility.Dir cleanup to SimpleBugDir.cleanup(). Still having a bit of trouble with the becommand.new tests due to bugdir loading though...
* Return to original directory after libbe.bugdir.SimpleBugDirTestCase().W. Trevor King2009-07-311-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This was causing strange "RCS not found" errors in the bzr and hg unittests. For example, the bzr tests all passed: wking@thor:be.wtk-rr$ python test.py bzr ... Ran 12 tests in 24.143s OK Except when run after the bugdir tests: wking@thor:be.wtk-rr$ python test.py bugdir bzr ... Ran 19 tests in 1.862s FAILED (errors=12) Where the failures were all AssertionError: bzr RCS not found Fixed by returning to intial directory after SimpleBugDirTestCase execution. Problem is due to Python issues with unlinked directories though, so bzr/hg will _still_ not work from unlinked directories. This is for Python 2.5.4 on Ubuntu 8.04.3, but probably effects other pythons too. Details: Isolated problem to unlinked directories: mkdir /tmp/a cd /tmp/a rmdir /tmp/a python /home/wking/src/fun/be/be.wtk-rr/test.py bzr which fails with the same "RCS not found" errors because bzr fails: wking@thor:/$ mkdir /tmp/a; cd /tmp/a; rmdir /tmp/a; bzr --help; cd /; rmdir: removing directory, /tmp/a 'import site' failed; use -v for traceback bzr: ERROR: Couldn't import bzrlib and dependencies. Please check bzrlib is on your PYTHONPATH. Traceback (most recent call last): File "/usr/bin/bzr", line 64, in <module> import bzrlib ImportError: No module named bzrlib which fails becase 'import site' fails: wking@thor:/$ mkdir /tmp/a; cd /tmp/a; rmdir /tmp/a; python -c 'import site'; cd /; rmdir: removing directory, /tmp/a 'import site' failed; use -v for traceback Traceback (most recent call last): File "<string>", line 1, in <module> File "/home/wking/lib/python/site.py", line 73, in <module> __boot() File "/home/wking/lib/python/site.py", line 33, in __boot imp.load_module('site',stream,path,descr) File "/usr/lib/python2.5/site.py", line 408, in <module> main() File "/usr/lib/python2.5/site.py", line 392, in main paths_in_sys = removeduppaths() File "/usr/lib/python2.5/site.py", line 96, in removeduppaths dir, dircase = makepath(dir) File "/usr/lib/python2.5/site.py", line 72, in makepath dir = os.path.abspath(os.path.join(*paths)) File "/usr/lib/python2.5/posixpath.py", line 403, in abspath path = join(os.getcwd(), path) OSError: [Errno 2] No such file or directory which fails because our cwd doesn't exist. That makes sense ;). Still I think Python should be able to handle it, so I reported it http://bugs.python.org/issue6612
* Removed libbe.bzr.Bzr's automerge on post-commit.W. Trevor King2009-07-311-14/+0
| | | | | | I'd done this already in wking@drexel.edu-20090723154304-swmkxpfagdzff9ai but for some reason the merge with the email branch brought it back.
* Fixed libbe.bugdir.BugDirTestCase.testComments(sync_with_disk=False).W. Trevor King2009-07-311-1/+1
|
* Fixed comment.cmp_attr unittest because "o" > "a" so cmp("o", "a") == 1.W. Trevor King2009-07-311-2/+2
|
* Fixed indent spacing in libbe.diff.report().W. Trevor King2009-07-311-20/+22
| | | | Only increment depth if data_part != None.
* Merged interactive email interfaceW. Trevor King2009-07-2975-465/+3539
|\
| * Corrected some problems with revision_id() before an initial commit.W. Trevor King2009-07-293-2/+19
| |
| * be-handle-mail no longer sends blank subscriber emails when no change occurs.W. Trevor King2009-07-271-4/+15
| | | | | | | | | | It had been mailing out the empty MIMEMultipart root returned by diff_tree.report().
| * Fixed _procmailrc rules.W. Trevor King2009-07-272-16/+20
| | | | | | | | | | | | "[" is a special character. Also a few minor cleanups in be-handle-mail.
| * Restored Makefile to /home/wking installationW. Trevor King2009-07-271-3/+3
| |
| * Cleaned up be-handle-mail's subscriber notification emails (fewer attachments).W. Trevor King2009-07-273-40/+88
| | | | | | | | | | | | | | | | | | | | | | Previously, every node in the DiffTree created it's own attachment. Now they're consolidated into a single attachment per bug. higher level nodes are still one attachment per node. Also: * added send_pgp_mime.append_text() * pulled guess_encoding() out of send_pgp_mime.encodedMIMEText(). * renamed data_string -> data_part in libbe.diff, since it needn't be a string.
| * Allow "subscribe" command via the email interface.W. Trevor King2009-07-271-1/+1
| |
| * Tweaked the output text for modified bugs in libbe.diff and be-handle-mail.W. Trevor King2009-07-272-2/+8
| |
| * Added "be-handle-mail --notify-since REVISION".W. Trevor King2009-07-271-27/+62
| |
| * Added an additional format check to be-handle-mail's pseudoheader parsing.W. Trevor King2009-07-273-2/+4
| | | | | | | | Marked outstanding email interface bugs as fixed.
| * Merged "be subscribe" and be-handle-mail subscription support.W. Trevor King2009-07-2730-394/+1648
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also assorted other changes and fixes in the be.subscribe branch. Highlights: * Much more powerful libbe.diff with subclassable report generators. * "be diff" compares working copy with last commit by default. * comment reference text shown in "be comment" EDITOR footer * .revision_id() for all VCSs * meaningful comment comparison and stricter bug comparison * stricter .sync_with_disk interpretation. See BugDir.__doc__. * Comment.From and .time_string -> .author and .date, for better conformance with settings_object.setting_name_to_attr_name().
| | * Subscribing myself to all changes.W. Trevor King2009-07-271-0/+4
| | |
| | * Moved be-handle-mail over to new libbe.diff classes.W. Trevor King2009-07-271-96/+49
| | |
| | * Removed debugging exception from libbe/comment.py.W. Trevor King2009-07-271-1/+0
| | |
| | * Comment.remove() now ignores .sync_with_disk when removing the root comment.W. Trevor King2009-07-271-1/+1
| | |
| | * Added default to settings_object.versioned_property's change_hook_property.W. Trevor King2009-07-273-19/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now change_hook properties handle defaults, which allows them to avoid an initial None -> default save hook trigger. Removed the now-redundant read-only mode business in becommands/diff.py.
| | * Put bd into read-only mode in becommands/diff.py.W. Trevor King2009-07-271-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | Otherwise comment comparison reads were triggering notice of the None -> EMPTY transition in comment.extra_strings, which was causing a write to disk. This trigger is probably occuring in Bug and BugDir too. Perhaps I should just remove the trigger...
| | * Added cmp functions to libbe.comment, and fleshed them out in libbe.bug.W. Trevor King2009-07-273-7/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previous comment comparison had just been the default Tree.__cmp__. Fleshed out so A == B ensures no meaningful differences between A and B. Also added first line of comments to new comment output in libbe.diff, and added a comment/"settings" node and .comment_mod_string() (to mirror bugdir and bug).
| | * Hack Comment.load_settings() to work around From->Author change.W. Trevor King2009-07-271-0/+3
| | | | | | | | | | | | | | | | | | "Author" -> comment.author obeys settings_object.setting_name_to_attr_name(), but all the current on-disk mapfiles talk about "From". Add a hack to accept both forms of on-disk comment files.
| | * Cache data strings in libbe.diff.DiffTree.W. Trevor King2009-07-271-0/+3
| | | | | | | | | | | | | | | This makes repeated .report() generation from the same tree more efficient.
| | * Major rewrite of libbe.diff introduces DiffTree and Diff classes.W. Trevor King2009-07-272-110/+395
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To make the interface proposed by becommands/subscribers.py easier to implement, I've moved the libbe.diff functionality into classes. Now it should be easy two tweak the output as desired by subclassing these classes. The basic idea is that Diff.report_tree() generates a diff_tree tree of changes between two bugdirs, where diff_tree is some subclass of DiffTree. Each type of change has a default .*_string() method producing a string summary of the change. DiffTree.report() moves through and generates a report by joining all those summary strings to a single root, and DiffTree.report_string() serialized the report to produce e.g. the output of becommands/diff.py.
| | * .sync_with_disk fixes for libbe.bugdir and .comment.W. Trevor King2009-07-272-4/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | In BugDir, only call bug.remove if bug.sync_with_disk==True. If it's just in memory, automatic garbage collection is sufficient cleanup. Comment.set_sync_with_disk() had been setting .sync_with_disk=True regardless of the value passed in. Fixed now. Also some minor textual adjustments.
| | * Added DiskAccessRequired errors to libbe.bug.Bug and .comment.Comment.W. Trevor King2009-07-262-98/+144
| | |
| | * BugDir._in_memory was a stupid idea. Took it back out.W. Trevor King2009-07-261-103/+147
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It was too confusing having three memory access levels: 1) syncronized 2) explicit 3) memory-only with .sync_with_disk selecting between 1 and 2/3 and ._in_memory selecting between 2/3. Now there are only two: 1) syncronized 2) memory-only excepting explicit BugDir.save() calls. I avoid the problem of non-syncronized loading of on-disk bugs in simple_bug_dir by restricting .list_uuids() to in-memory bugs when .sync_with_disk==True. Beyond that, I shifted the order of the BugDir methods around a bit so that they were better grouped according to general idea. Note that the DiskAccessRequired exceptions on filesystem access when .sync_with_disk==False should be propogated to the Bug and Comment methods, but I haven't done that yet.
| | * Added in_memory to BugDir.__init__ to disable saving/loading completely.W. Trevor King2009-07-251-17/+77
| | | | | | | | | | | | | | | | | | | | | The previous simple_bug_dir(on_disk==False) supprised me by loading my BE bugdir when called from the BE directory. This functionality could probably move out to Bug and Comment as well, but I have avoided that for now.
| | * Added on_disk option to libbe.bugdir.simple_bug_dir().W. Trevor King2009-07-251-6/+14
| | | | | | | | | | | | Now you can easily generate simple_bug_dirs that live only in memory.
| | * Renamed Comment.From and .time_string to .author and .date respectively.W. Trevor King2009-07-254-35/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now they conform to the libbe.settings_object.setting_name_to_attr_name() standard. I fixed the references I found in becommands/comment.py interfaces/xml/be-mbox-to-xml interfaces/xml/be-xml-to-mbox but there may have been some references or files that slipped through.
| | * Added autocommit wishlist request by Martin KrafftW. Trevor King2009-07-245-0/+65
| | |
| | * be-handle-mail successfully generates bugdir-changed notification emails.W. Trevor King2009-07-231-7/+180
| | | | | | | | | | | | | | | This still needs a lot of cleaning up, but it worked for an "all" subscription to "DIR", so I thought I'd lock in the current status ;).
| | * "be diff" now compares agains the last commit (for versioning VCSs).W. Trevor King2009-07-231-0/+2
| | | | | | | | | | | | This is the default behaviour of most of the VCSs own diff commands.
| | * Added .revision_id() to all the VCSs.W. Trevor King2009-07-236-24/+114
| | | | | | | | | | | | | | | This makes it easier to compare recent revisions without a human around to give you revision numbers.
| | * Broke encodedMIMEText out of send-pgp-mime.PGPMimeMessageFactory.W. Trevor King2009-07-231-20/+21
| | | | | | | | | | | | | | | It's useful enough even when you're not intending to encrypt something.
| | * Added Tree types and get_bugdir_subscribers to becommands/subscribe.py.W. Trevor King2009-07-231-83/+214
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Tree subclass SubscriptionType may be a few more lines to setup, but they should be really easy to extend and will automatically keep the longhelp and type handling in sync. An example extension for bugdir types would be all -> assigned -> <user> to subscribe only to bugs being assigned to the specified user. You'd have to loosen the currently strict InvalidType checking to make that work, but the current type-tree handling would be up to the task. Also a bit of reorganizing to hide the private functions.
| | * Merged libbe.diff upgrades and libbe.tree.Tree.has_descendant from be.wtk-rr.W. Trevor King2009-07-235-37/+89
| | |\ | | | | | | | | | | | | Also pulls "show referenced text" fix to "be comment".
| | * | Added comment on notification granularity (commit-level).W. Trevor King2009-07-232-0/+18
| | | |
| | * | Added becommands/subscribe.py to manage subscription list.W. Trevor King2009-07-223-0/+250
| |/ /
| * | Merged assorted changes from be.wtk-rr for BugDir.extra_strings.W. Trevor King2009-07-21167-119/+4464
| |\ \ | | | | | | | | | | | | | | | | | | | | | | | | Other highlights: * be show --no-comments * Improved *.sync_with_disk. * Improved be-mbox-to-xml.
| * | | Added: subscribe/unsubscribe (bug #..., "new bugs", "all", etc.)W. Trevor King2009-07-219-0/+100
| | | |
| * | | Use shlex.split() to parse control lines in be-handle-mail.W. Trevor King2009-07-203-16/+14
| | | | | | | | | | | | | | | | Split arguments following POSIX rather than at all whitespace.
| * | | Added pseudo-header list to interfaces/email/interactive/README.W. Trevor King2009-07-201-14/+17
| | | | | | | | | | | | | | | | Also some minor textual cleanups.
| * | | Added psuedo-header handling to be-handle-mail.W. Trevor King2009-07-202-4/+25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Many psuedo-headers had been ignored. Now they are all implemented. Getting this working exposed a few bugs in error message generation for Commands with IDs in their argument list. These bugs should now be fixed.
| * | | Added more VCSs to the delete-commit notes in interfaces/README.W. Trevor King2009-07-201-7/+25
| | | |
| * | | Added interfaces/email/interactive/README and be-handle-mail options.W. Trevor King2009-07-202-11/+248
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The README should give enough info to install and use the interface. While I was writing it, I thought that be-handle-mail could use the --be-dir, --tag-base, and --test options. generate_global_tags() helps implement the --tag-base option. I set up a unittest framework since checking is currently a pipe-in-emails-by-hand sort of arrangement, which can be slow ;). Currently only generate_global_tags() is tested. I also restored "show" to ALLOWED_COMMANDS, since it seems to have wandered off ;).
| * | | be-handle-mail shown to successfully commit partially-failing emails.W. Trevor King2009-07-191-0/+18
| | | | | | | | | | | | | | | | I've added the test-case that show it.