aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* Oops, fixed return typo in libbe.darcs.Darcs._vcs_get_file_contents()W. Trevor King2009-10-061-8/+8
| | | | | | | | | | | | | | | For self.parsed_version[0] >= 2, was returning the entire output of ._u_invoke_client() (status, output, and error). Now it just returns the output, which is what we want. This fixes Chris' failed test: ====================================================================== FAIL: Should get file contents as committed to specified revision. ---------------------------------------------------------------------- Traceback (most recent call last): File "libbe/vcs.py", line 852, in test_revision_file_contents_as_committed self.test_contents['rev_1'], committed_contents) AssertionError: 'Lorem ipsum' != (0, 'Lorem ipsum', '') ----------------------------------------------------------------------
* Moved VCS detection from _vcs_help() to _vcs_version().W. Trevor King2009-10-066-22/+29
| | | | | | | The version string is useful information to have around, while the help string is probably not. For example, we use it in darcs.Darcs._vcs_get_file_contents() to construct an incantation appropriate to the version we're dealing with.
* Moved from *.__del__() to exclusive use of *.cleanup().W. Trevor King2009-10-055-15/+10
| | | | | | | | | *.__del__() is run some unspecified time after the refcount for an object is reduced to zero. Sometimes that means that the rest of the world has already been deallocated, which makes life difficult, especially when Python won't attempt to construct stack traces inside *.__del__(). We were always (hopefully ;) calling del(*) anyway, so we just replace those calls with *.cleanup()
* Set self.ret if necessary in be-handle-mail.Command.response_msg().W. Trevor King2009-09-261-0/+1
| | | | | If an exception is raised during command exection, self.ret may be left at None.
* Added "Confirm" and "Subscribe" pseudoheaders to be-handle-mail.W. Trevor King2009-09-261-8/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Allowed values for both are "yes" or "no", case insensitive. Setting Confirm:no disables the confirmation email letting you know your new bug was successfully submitted. Setting Subscribe:yes automatically subscribes you to the new bug you're submitting immediately, without reqiring an extra control email. In the case where both Confirm:yes and Subscribe:yes, the submitter will only recieve the subscription email (which shows the "be show" view of the new bug) and not the submission email (which shows the output of all the executed submission commands). Both of these pseudoheaders were in response to a Would you like a direct response concerning your comments? checkbox on the web frontend that generates emails for a BE repo. When the checkbox is set, we set Confirm:yes Subscribe:yes, and the submitter gets a nice pretty confirmation email and will be automatically notified of any future action on their bug. When the checkbox is not set, they get no response or submission emails. Also fixed up some bugs in in the subscriber_emails() parsing. We now use ordered_subscriptions to ensure that we parse the "DIR" subscription first, since we don't want to include the same information twice, and the user might be subscribed to DIR:all and a particular bug (which would be wierd, but is easily avoidable). This also ensures that the more central DIR level changes appear first in the email. We also check that there is an entry for a particular bug in bug_index before attempting to grab it, which could raise KeyErrors otherwise. Finally, we check to make sure we don't double-include bugs for which the user is subscribed to both that bug's new and DIR:new. A final minor correction is the capitalization of the first word of our log entries. The logs are pretty cluttered, and the capitalization helps the lines I care about stand out. A better solution would be to come up with a cleaner idea of what to write to the logs...
* Load bugs in be-handle-mail.Message.subscriber_emails().W. Trevor King2009-09-261-0/+2
| | | | | Because subscribe.get_bugdir_subscribers() only looks for subscribers in bugs that are already in memory.
* Fix agressive be-handle-mail.Message._strip_footer().W. Trevor King2009-09-261-0/+1
| | | | | | It had been eating the last line of the message (which wasn't a problem when I had a blank line before the footer, but was when I had neither footer nor trailing blank line).
* Prefix cache attributes in be-handle-mail with underscore (_).W. Trevor King2009-09-261-5/+5
| | | | | To conform with Python convention for "hiding" class attributes only intended for internal use.
* Fixed invalid TAG error in becommands.subscribe.get_subscribers()W. Trevor King2009-09-261-0/+2
| | | | | Check that the string has the right tag before attempting to parse it :p.
* Added -a and -l options to be subscribe.W. Trevor King2009-09-261-11/+29
| | | | | It's useful to have some way to see the current subscription status from the command line ;).
* Added normalize_RFC_2822_date() to be-mbox-to-xml.W. Trevor King2009-09-231-3/+21
| | | | | | | | | | The if new_fields[u'date'] != None: bit avoids attemting to normalize missing dates (which fails). You get messages with missing dates when comment_message_to_xml() is called recursively for multipart messages. Also fixed some unicode keys (['X'] -> [u'X']) for consistency.
* Added normalize_email_address() to be-mbox-to-xmlW. Trevor King2009-09-231-1/+4
|
* Fixed mutliple in-reply-to splitting in be-mbox-to-xmlW. Trevor King2009-09-231-1/+3
|
* Fixed bugdir name collision in cmdutil.bug_from_shortname()W. Trevor King2009-09-231-2/+2
|
* Use Bug.active to decide active status in becommands/html.pyW. Trevor King2009-09-231-1/+1
|
* Convert incoming text/* email payloads to unicode in be-handle-mail.W. Trevor King2009-09-232-10/+9
| | | | | | | | | | | | | | | Switched from cStringIO to StringIO in be-handle-mail because: (from http://docs.python.org/library/stringio.html) "Unlike the memory files implemented by the StringIO module, those provided by this [cStringIO] module are not able to accept Unicode strings that cannot be encoded as plain ASCII strings." I'm not sure what all the fuss with sys.__stdin__ had been about in Command.run(), but I took it out and everything still seems to work ;). Also fix Makefail (again!) to install under $HOME by default.
* os.path.isdir() -> .exists() for check for "comments" file.W. Trevor King2009-09-211-1/+1
| | | | | | | | | "comments" should always be a directory if it exists, but if it is something else, be should fail rather than return an empty comment list. This fix was inspired by some browsing around in response to Thomas Habets' version of a fix for missing "bugs" directory.
* Include stdout in CommandError.W. Trevor King2009-09-193-8/+9
|
* Fixed email.Parser typo in send_pgp_mime.py imports for Python 2.4.W. Trevor King2009-09-171-1/+1
|
* Added `be --verbose-version' option to print full version information.W. Trevor King2009-09-151-2/+4
|
* Added libbe.version, wrapping the auto-generated libbe._version.W. Trevor King2009-09-152-2/+52
| | | | | | | | | | | | | | | | Two major benefits: 1) Programatic access to the BE version. Previously the version-string logic was internal to the commandline interface ./be, which left the other interfaces hanging. 2) Simple to override auto-generated revision id version with any string you like (by setting libbe.version._VERSION, if that's the way you want to run things or the way your packaging system requires. Note that other modules should never read libbe.version._VERSION, since it may not be defined. Instead they should use the output of libbe.version.version().
* Fixed a few typos in be-handle-mailW. Trevor King2009-09-131-4/+4
|
* Mention commit message in interactive email README subject explaination.W. Trevor King2009-09-131-2/+2
|
* Explicitly set encoding to UTF-8.W. Trevor King2009-09-131-0/+3
| | | | | Because otherwise we run into problems when running be from inside cron jobs.
* Typo EncryptedMessageFactory -> PGPMimeMessageFactory in send-pgp-mime.pyW. Trevor King2009-09-111-2/+2
| | | | | | I changed the class name in commit wking@drexel.edu-20090718201613-n242qfl4s3j3kfjf but missed two references.
* Added docstrings to libbe submodules.W. Trevor King2009-08-3121-32/+126
| | | | Also a few minor tweaks to the module imports.
* BugDir.duplicate_bugdir() fix for when parent bugdir's sync_with_disk == False.W. Trevor King2009-08-311-2/+8
|
* RCS -> VCS, BUGDIR_DISK_VERSION -> v1.2W. Trevor King2009-08-3121-494/+510
|
* Merged be.on-disk-upgrade, which added libbe.upgradeW. Trevor King2009-08-31187-1217/+806
|\
| * Use 'v#.#' for major/minor version in upgrade.BUGDIR_DISK_VERSIONSW. Trevor King2009-08-312-2/+2
| |
| * Upgrade duplicate bugdirs if necessary (e.g. for `be diff').W. Trevor King2009-08-313-20/+49
| | | | | | | | | | Also moved pre-YAML mapfile handling in mapfile.parse() into upgrade.Upgrade_1_0_to_2._upgrade_mapfile().
| * Added libbe/upgrade.py to handle upgrading on-disk bugdirs.W. Trevor King2009-08-31177-1164/+702
| |
| * Made get_path() definitions consistent between bugdirs, bugs, and comments.W. Trevor King2009-08-314-15/+32
| |
| * Bug 22b (target-bugs) blocked by 519 (on-disk upgrade) and assigned to TrevorW. Trevor King2009-08-318-19/+24
|/
* VCS vs. RCS terminology blocked by on-disk upgrade path.W. Trevor King2009-08-312-0/+8
|
* Added comment 22b:7 about representing targets with Bug() instances.W. Trevor King2009-08-312-0/+67
|
* Broke up be-handle-mail.parse() into parse_new(), _comment(), and _control().W. Trevor King2009-08-161-57/+75
| | | | Also fleshed out the be-handle-mail docstring.
* Added on-disk representation upgrade bugW. Trevor King2009-08-163-0/+41
|
* Handle BugDir.list_uuids() in the case of missing ".be/bugs/".W. Trevor King2009-08-111-4/+5
| | | | | | | | | | Previously: $ be init $ be list ... File ".../libbe/bugdir.py", line 537, in list_uuids for uuid in os.listdir(self.get_path("bugs")): OSError: [Errno 2] No such file or directory: '.../.be/bugs'
* "be html" fixes bug 2f0W. Trevor King2009-08-081-1/+1
|
* Oops, update comment.From->author and .time_string->.date in becommands/html.pyW. Trevor King2009-08-081-2/+2
|
* Updated AUTHORS and copyright info for becommands/html.py.W. Trevor King2009-08-072-19/+23
| | | | | | | | | Also adjusted update_copyright.sh to ignore Gianluca's temporary use of gianluca <gian@galactica> since he's now using Gianluca Montecchi <gian@grys.it> on becommands/html.py.
* Merged Gianluca's html output branch.W. Trevor King2009-08-0710-0/+716
|\ | | | | | | | | | | | | | | | | | | | | | | Changes to merge with my branch: * Added some reference to "be html" or "becommands/html.py" in his new bugs' summaries. Bug titles should make clear to which aspect of our growing repository they refer. * Fixed unittests in becommands/html.py. * execute() kwarg "test"->!"manipulate_encodings * bugdir.simple_bug_dir() -> bugdir.SimpleBugDir() * bd.cleanup() at end of unittests
| * Sort bugs in HTML output.W. Trevor King2009-08-071-1/+1
| |
| * XHTML attribute values should be strings, and cellspacing not allowed in tr.W. Trevor King2009-08-071-8/+8
| |
| * Escape HTML entities (e.g. & and @) in HTML outputW. Trevor King2009-08-071-25/+33
| |
| * XHTML tags must be closed (e.g. <br />, not <br>)W. Trevor King2009-08-071-2/+2
| |
| * XHTML attribute values should be strings.W. Trevor King2009-08-071-1/+1
| |
| * Protect bug html from libbe.settings_object.EMPTYW. Trevor King2009-08-071-8/+12
| |
| * Added DOCTYPE to detail html as wellW. Trevor King2009-08-071-0/+2
| |