Fixed libbe.command.diff + ugly BugDir.duplicate_bugdir implementation

duplicate_bugdir() works, but for the vcs backends, it could require
shelling out for _every_ file read.  This could, and probably will, be
horribly slow.  Still it works ;).

I'm not sure what a better implementation would be.  The old
implementation checked out the entire earlier state into a temporary
directory
  pros: single shell out, simple upgrade implementation
  cons: wouldn't work well for HTTP backens

I think a good solution would run along the lines of the currently
commented out code in duplicate_bugdir(), where a
  VersionedStorage.changed_since(revision)
call would give you a list of changed files.  diff could work off of
that directly, without the need to generate a whole duplicate bugdir.
I'm stuck on how to handle upgrades though...

Also removed trailing whitespace from all python files.

1 files changed, 3 insertions, 3 deletions

diff --git a/libbe/command/subscribe.py b/libbe/command/subscribe.py
index 4f72624..a837f99 100644
--- a/libbe/command/subscribe.py
+++ b/libbe/command/subscribe.py
@@ -131,7 +131,7 @@ class Subscribe (libbe.command.Command):
                 params['types'] = 'all'
         servers = params['servers'].split(',')
         types = params['types'].split(',')
-    
+
         if len(params['id']) == 0:
             params['id'] = [libbe.diff.BUGDIR_ID]
         for _id in params['id']:
@@ -159,7 +159,7 @@ class Subscribe (libbe.command.Command):
                 else: # add the tag
                     estrs = subscribe(estrs, subscriber, types, servers, type_root)
                 entity.extra_strings = estrs # reassign to notice change
-        
+
             if params['list-all'] == True:
                 bugdir.load_all_bugs()
                 subscriptions = get_bugdir_subscribers(bugdir, servers[0])
@@ -168,7 +168,7 @@ class Subscribe (libbe.command.Command):
                 for estr in entity.extra_strings:
                     if estr.startswith(TAG):
                         subscriptions.append(estr[len(TAG):])
-    
+
             if len(subscriptions) > 0:
                 print >> self.stdout, 'Subscriptions for %s:' % entity_name
                 print >> self.stdout, '\n'.join(subscriptions)