diff options
author | W. Trevor King <wking@drexel.edu> | 2009-12-04 22:44:12 -0500 |
---|---|---|
committer | W. Trevor King <wking@drexel.edu> | 2009-12-04 22:44:12 -0500 |
commit | 4cb0182da105d18f067c1a10482c89c966b02827 (patch) | |
tree | f6c22ca2453aa6f51964ad8644b3f696e3a294a8 | |
parent | 8bcbda7e3c022b6d63d86123b3aacabbe6c21ec1 (diff) | |
download | bugseverywhere-4cb0182da105d18f067c1a10482c89c966b02827.tar.gz |
Use __cmp__ instead of __eq__ for Tree comparison.
This ensures that __ne__ will also work, and makes it easier to
subclass Tree. For example, in the previous implementation you could
have
>>> commA == commB
False
>>> cmp(commA, commB)
0
if the comments had different ids, but equivalent content.
At the user-interface level, this removes some false "modified
comments" from `be diff`.
-rw-r--r-- | libbe/tree.py | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/libbe/tree.py b/libbe/tree.py index 8077da7..d3f6bcd 100644 --- a/libbe/tree.py +++ b/libbe/tree.py @@ -84,8 +84,8 @@ class Tree(list): >>> a.has_descendant(a, match_self=True) True """ - def __eq__(self, other): - return id(self) == id(other) + def __cmp__(self, other): + return cmp(id(self), id(other)) def branch_len(self): """ |