diff options
author | W. Trevor King <wking@drexel.edu> | 2008-11-22 19:45:37 -0500 |
---|---|---|
committer | W. Trevor King <wking@drexel.edu> | 2008-11-22 19:45:37 -0500 |
commit | 4a626e67b3f401b8e242a55571a802147123a196 (patch) | |
tree | e5907e6e16e9110a092d723e43f34571a4cac378 /.be/bugs/c894f10f-197d-4b22-9c5b-19f394df40d4 | |
parent | 9524d061aa93451a282f45150944878d6b5cf065 (diff) | |
download | bugseverywhere-4a626e67b3f401b8e242a55571a802147123a196.tar.gz |
Explicit rcs.cleanup() in bugdir test.
Don't use del(rcs), because if there was an error, there is still a
reference to rcs in the traceback, so it is never cleaned up. This
can leave the external archive cluttering up your Arch install if
you're using the Arch backend. See the __del__ documentation
http://python.active-venture.com/ref/customization.html#l2h-175
for details.
Also fixed some out-of-date method names in libbe.diff
Diffstat (limited to '.be/bugs/c894f10f-197d-4b22-9c5b-19f394df40d4')
3 files changed, 73 insertions, 0 deletions
diff --git a/.be/bugs/c894f10f-197d-4b22-9c5b-19f394df40d4/comments/208595bd-35b8-44c2-bf97-fc5ef9e7a58d/body b/.be/bugs/c894f10f-197d-4b22-9c5b-19f394df40d4/comments/208595bd-35b8-44c2-bf97-fc5ef9e7a58d/body new file mode 100644 index 0000000..7f46872 --- /dev/null +++ b/.be/bugs/c894f10f-197d-4b22-9c5b-19f394df40d4/comments/208595bd-35b8-44c2-bf97-fc5ef9e7a58d/body @@ -0,0 +1,17 @@ +Example: + +We're working happily in a versioned bugdir, and our RCS knows who we +are. We create a temporary repository copy from a previous revision +for diff generation. We set the RCS for the copy to "None", since we +didn't bother initializing our normal RCS in the snapshot copy. But +now the BugDir instantized on the copy doesn't know who we are! + +Solution: + +Track user id in the bugdir settings file. If you +bugdir.settings["user_id"], it will be saved and loaded. When loaded, +it will also set bugdir.user_id. If you set rcs.user_id, it will be +returned by rcs.get_user_id(), instead of returing the output of +rcs._rcs_get_user_id(). We should be caching the output of +_rcs_get_user_id() anyway. + diff --git a/.be/bugs/c894f10f-197d-4b22-9c5b-19f394df40d4/comments/208595bd-35b8-44c2-bf97-fc5ef9e7a58d/values b/.be/bugs/c894f10f-197d-4b22-9c5b-19f394df40d4/comments/208595bd-35b8-44c2-bf97-fc5ef9e7a58d/values new file mode 100644 index 0000000..368afb3 --- /dev/null +++ b/.be/bugs/c894f10f-197d-4b22-9c5b-19f394df40d4/comments/208595bd-35b8-44c2-bf97-fc5ef9e7a58d/values @@ -0,0 +1,21 @@ + + + +Content-type=text/plain + + + + + + +Date=Sat, 22 Nov 2008 21:43:29 +0000 + + + + + + +From=W. Trevor King <wking@drexel.edu> + + + diff --git a/.be/bugs/c894f10f-197d-4b22-9c5b-19f394df40d4/values b/.be/bugs/c894f10f-197d-4b22-9c5b-19f394df40d4/values new file mode 100644 index 0000000..9992d72 --- /dev/null +++ b/.be/bugs/c894f10f-197d-4b22-9c5b-19f394df40d4/values @@ -0,0 +1,35 @@ + + + +creator=W. Trevor King <wking@drexel.edu> + + + + + + +severity=minor + + + + + + +status=open + + + + + + +summary=Allow user id to be cached in settings for duplicate bugdirs + + + + + + +time=Sat, 22 Nov 2008 21:36:06 +0000 + + + |